Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1358)

Unified Diff: content/browser/tab_contents/tab_contents.h

Issue 7880003: content: Move constrained window code from TabContents to TabContentsWrapper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix mac compile (add forward declaration to file that didn't have it) Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | content/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tab_contents/tab_contents.h
diff --git a/content/browser/tab_contents/tab_contents.h b/content/browser/tab_contents/tab_contents.h
index 64bca21c33167abcb133dd582852b94949b6c4da..c023d30a257c24b81a2e1cae6e91dd96ab9dd287 100644
--- a/content/browser/tab_contents/tab_contents.h
+++ b/content/browser/tab_contents/tab_contents.h
@@ -297,29 +297,12 @@ class CONTENT_EXPORT TabContents : public PageNavigator,
// Window management ---------------------------------------------------------
- // Adds the given window to the list of child windows. The window will notify
- // via WillClose() when it is being destroyed.
- void AddConstrainedDialog(ConstrainedWindow* window);
-
// Adds a new tab or window with the given already-created contents.
void AddNewContents(TabContents* new_contents,
WindowOpenDisposition disposition,
const gfx::Rect& initial_pos,
bool user_gesture);
- // Returns the number of constrained windows in this tab. Used by tests.
- size_t constrained_window_count() { return child_windows_.size(); }
-
- typedef std::deque<ConstrainedWindow*> ConstrainedWindowList;
-
- // Return an iterator for the first constrained window in this tab contents.
- ConstrainedWindowList::iterator constrained_window_begin()
- { return child_windows_.begin(); }
-
- // Return an iterator for the last constrained window in this tab contents.
- ConstrainedWindowList::iterator constrained_window_end()
- { return child_windows_.end(); }
-
// Views and focus -----------------------------------------------------------
// TODO(brettw): Most of these should be removed and the caller should call
// the view directly.
@@ -365,9 +348,6 @@ class CONTENT_EXPORT TabContents : public PageNavigator,
// Notifies the delegate that a download started.
void OnStartDownload(DownloadItem* download);
- // Called when a ConstrainedWindow we own is about to be closed.
- void WillClose(ConstrainedWindow* window);
-
// Interstitials -------------------------------------------------------------
// Various other systems need to know about our interstitials.
@@ -596,8 +576,6 @@ class CONTENT_EXPORT TabContents : public PageNavigator,
// up at the next animation step if the throbber is going.
void SetNotWaitingForResponse() { waiting_for_response_ = false; }
- ConstrainedWindowList child_windows_;
-
// Navigation helpers --------------------------------------------------------
//
// These functions are helpers for Navigate() and DidNavigate().
@@ -614,9 +592,6 @@ class CONTENT_EXPORT TabContents : public PageNavigator,
const content::LoadCommittedDetails& details,
const ViewHostMsg_FrameNavigate_Params& params);
- // Closes all constrained windows.
- void CloseConstrainedWindows();
-
// If our controller was restored and the page id is > than the site
// instance's page id, the site instances page id is updated as well as the
// renderers max page id.
@@ -732,9 +707,6 @@ class CONTENT_EXPORT TabContents : public PageNavigator,
// RenderViewHostManager::Delegate -------------------------------------------
- // Blocks/unblocks interaction with renderer process.
- void BlockTabContent(bool blocked);
-
virtual void BeforeUnloadFiredFromRenderManager(
bool proceed,
bool* proceed_to_fire_unload);
« no previous file with comments | « chrome/chrome_tests.gypi ('k') | content/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698