bluetooth: Use BluetoothAdapter in BluetoothDispatcherHost.

bluetooth: Use BluetoothAdapter in BluetoothDispatcherHost.

Previously only simple mock responses were supported in
BluetoothDispatcherHost. This change adds use of an actual adapter,
and enables the first actual bluetooth.requestDevices responses
to function in the browser (with the experimental-web-platform-features
flag).

BUG=420284
Committed: https://crrev.com/87f458906d9fb18e31ab051cd2e182550f1e15af
Cr-Commit-Position: refs/heads/master@{#312241}

[scheib, 2014-12-10 00:16:27]

Patchset #1 (id:1) has been deleted

[scheib, 2014-12-10 00:17:53]

scheib@chromium.org changed reviewers:
+ armansito@chromium.org

[scheib, 2014-12-10 00:17:54]

armansito, please take a first-pass look, I will also be adding OWNERS for the
build files and content/browser/renderer_host/render_process_host_impl.cc after
first pass.

[armansito, 2014-12-10 00:40:05]

A couple of comments. As a note, all classes defined in device/bluetooth have
mock subclasses in device/bluetooth/test, so you can use them to unit test your
code in the future.

https://codereview.chromium.org/787953004/diff/20001/content/browser/bluetoot...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/787953004/diff/20001/content/browser/bluetoot...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:66: // Mock
implementation util a more complete implementation is built out.
nit: s/util/until/ ?

https://codereview.chromium.org/787953004/diff/20001/content/browser/bluetoot...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:71:
BluetoothAdapter::DeviceList devices = adapter_->GetDevices();
I don't know what the final behavior will look like in the end but the correct
way to find devices is to not only check within GetDevices but also to initiate
device discovery and observing new devices via
BluetoothAdapter::Observer::DeviceAdded.

[scheib, 2014-12-10 17:51:31]

Patchset #3 (id:60001) has been deleted

[scheib, 2014-12-10 17:54:02]

Thanks Arman. Yes, this is incremental and so far just has 'empty mocks'. The
plan is to configure the real mocks using the bluetooth/test mock classes set as
the adapter.

https://codereview.chromium.org/787953004/diff/20001/content/browser/bluetoot...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/787953004/diff/20001/content/browser/bluetoot...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:66: // Mock
implementation util a more complete implementation is built out.
On 2014/12/10 00:40:04, armansito wrote:
> nit: s/util/until/ ?

Done.

https://codereview.chromium.org/787953004/diff/20001/content/browser/bluetoot...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:71:
BluetoothAdapter::DeviceList devices = adapter_->GetDevices();
On 2014/12/10 00:40:04, armansito wrote:
> I don't know what the final behavior will look like in the end but the correct
> way to find devices is to not only check within GetDevices but also to
initiate
> device discovery and observing new devices via
> BluetoothAdapter::Observer::DeviceAdded.

Done.

[armansito, 2014-12-10 18:14:35]

The Bluetooth related bits in BluetoothDispatcherHost and device/bluetooth in
DEPS lgtm

[scheib, 2014-12-16 21:52:37]

Patchset #3 (id:80001) has been deleted

[scheib, 2014-12-16 21:56:27]

scheib@chromium.org changed reviewers:
+ brettw@chromium.org

[scheib, 2014-12-16 21:57:04]

brettw OWNERS review please for:
content/browser/renderer_host/render_process_host_impl.cc
content/browser/DEPS
content/browser/BUILD.gn

[scheib, 2015-01-06 22:01:53]

brettw, ping

[brettw, 2015-01-07 08:45:45]

LGTM, sorry

[brettw, 2015-01-07 08:45:53]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-01-07 08:46:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787953004/120001

[commit-bot: I haz the power, 2015-01-07 08:49:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-07 08:49:36]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[scheib, 2015-01-08 19:23:22]

Patchset #4 (id:120001) has been deleted

[scheib, 2015-01-08 19:30:27]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-01-08 19:32:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787953004/140001

[commit-bot: I haz the power, 2015-01-08 19:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 19:32:33]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
in order for the CQ to process them

[scheib, 2015-01-08 20:05:36]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-01-08 20:06:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787953004/160001

[scheib, 2015-01-08 20:17:22]

Patchset #4 (id:140001) has been deleted

[commit-bot: I haz the power, 2015-01-08 21:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 21:11:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2015-01-08 23:37:55]

This issue is blocked on
https://code.google.com/p/chromium/issues/detail?id=447387.

Patch 5 illustrates the errors of referencing DBusThreadManager.

I'll fix that issue before landing this patch.

[scheib, 2015-01-17 23:02:48]

Patchset #5 (id:180001) has been deleted

[scheib, 2015-01-17 23:02:59]

Patchset #5 (id:200001) has been deleted

[scheib, 2015-01-19 17:17:12]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-01-19 17:18:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787953004/240001

[scheib, 2015-01-19 17:19:14]

Patchset #5 (id:220001) has been deleted

[commit-bot: I haz the power, 2015-01-19 17:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-19 17:22:22]

Try jobs failed on following builders:
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[scheib, 2015-01-20 04:15:42]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-01-20 04:16:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787953004/260001

[scheib, 2015-01-20 05:03:51]

Patchset #5 (id:240001) has been deleted

[commit-bot: I haz the power, 2015-01-20 05:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-20 05:20:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2015-01-20 18:12:05]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-01-20 18:13:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787953004/280001

[commit-bot: I haz the power, 2015-01-20 19:20:13]

Committed patchset #6 (id:280001)

[commit-bot: I haz the power, 2015-01-20 19:21:03]

Patchset 6 (id:??) landed as
https://crrev.com/87f458906d9fb18e31ab051cd2e182550f1e15af
Cr-Commit-Position: refs/heads/master@{#312241}