Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2011 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 #import "ios/chrome/browser/net/image_fetcher.h" | |
| 6 | |
| 7 #import <UIKit/UIKit.h> | |
| 8 | |
| 9 #include "base/mac/bind_objc_block.h" | |
| 10 #include "base/memory/scoped_ptr.h" | |
| 11 #include "base/message_loop/message_loop_proxy.h" | |
| 12 #include "base/run_loop.h" | |
| 13 #include "base/threading/sequenced_worker_pool.h" | |
| 14 #include "net/http/http_response_headers.h" | |
| 15 #include "net/url_request/test_url_fetcher_factory.h" | |
| 16 #include "net/url_request/url_fetcher_delegate.h" | |
| 17 #include "net/url_request/url_request_test_util.h" | |
| 18 #include "testing/gtest/include/gtest/gtest.h" | |
| 19 #include "testing/platform_test.h" | |
| 20 | |
| 21 namespace { | |
| 22 | |
| 23 static unsigned char jpgImage[] = { | |
|
droger
2014/12/11 16:28:32
Nit: kJPGImage, and same below.
| |
| 24 255,216,255,224,0,16,74,70,73,70,0,1,1,1,0,72,0,72,0,0,255,254,0,19,67, | |
| 25 114,101,97,116,101,100,32,119,105,116,104,32,71,73,77,80,255,219,0,67, | |
| 26 0,5,3,4,4,4,3,5,4,4,4,5,5,5,6,7,12,8,7,7,7,7,15,11,11,9,12,17,15,18,18, | |
| 27 17,15,17,17,19,22,28,23,19,20,26,21,17,17,24,33,24,26,29,29,31,31,31, | |
| 28 19,23,34,36,34,30,36,28,30,31,30,255,219,0,67,1,5,5,5,7,6,7,14,8,8,14, | |
| 29 30,20,17,20,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30, | |
| 30 30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30, | |
| 31 30,30,30,30,30,30,30,30,255,192,0,17,8,0,1,0,1,3,1,34,0,2,17,1,3,17,1, | |
| 32 255,196,0,21,0,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,8,255,196,0,20,16,1, | |
| 33 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,255,196,0,20,1,1,0,0,0,0,0,0,0,0,0,0, | |
| 34 0,0,0,0,0,0,255,196,0,20,17,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,255,218, | |
| 35 0,12,3,1,0,2,17,3,17,0,63,0,178,192,7,255,217 | |
| 36 }; | |
| 37 | |
| 38 static unsigned char pngImage[] = { | |
| 39 137,80,78,71,13,10,26,10,0,0,0,13,73,72,68,82,0,0,0,1,0,0,0,1,1,0,0,0, | |
| 40 0,55,110,249,36,0,0,0,2,98,75,71,68,0,1,221,138,19,164,0,0,0,9,112,72, | |
| 41 89,115,0,0,11,18,0,0,11,18,1,210,221,126,252,0,0,0,9,118,112,65,103,0, | |
| 42 0,0,1,0,0,0,1,0,199,149,95,237,0,0,0,10,73,68,65,84,8,215,99,104,0,0, | |
| 43 0,130,0,129,221,67,106,244,0,0,0,25,116,69,88,116,99,111,109,109,101, | |
| 44 110,116,0,67,114,101,97,116,101,100,32,119,105,116,104,32,71,73,77,80, | |
| 45 231,175,64,203,0,0,0,37,116,69,88,116,100,97,116,101,58,99,114,101,97, | |
| 46 116,101,0,50,48,49,49,45,48,54,45,50,50,84,49,54,58,49,54,58,52,54,43, | |
| 47 48,50,58,48,48,31,248,231,223,0,0,0,37,116,69,88,116,100,97,116,101,58, | |
| 48 109,111,100,105,102,121,0,50,48,49,49,45,48,54,45,50,50,84,49,54,58,49, | |
| 49 54,58,52,54,43,48,50,58,48,48,110,165,95,99,0,0,0,17,116,69,88,116,106, | |
| 50 112,101,103,58,99,111,108,111,114,115,112,97,99,101,0,50,44,117,85,159, | |
| 51 0,0,0,32,116,69,88,116,106,112,101,103,58,115,97,109,112,108,105,110, | |
| 52 103,45,102,97,99,116,111,114,0,50,120,50,44,49,120,49,44,49,120,49,73, | |
| 53 250,166,180,0,0,0,0,73,69,78,68,174,66,96,130 | |
| 54 }; | |
| 55 | |
| 56 static unsigned char webpImage[] = { | |
| 57 82,73,70,70,74,0,0,0,87,69,66,80,86,80,56,88,10,0,0,0,16,0,0,0,0,0,0,0,0,0, | |
| 58 65,76,80,72,12,0,0,0,1,7,16,17,253,15,68,68,255,3,0,0,86,80,56,32,24,0,0,0, | |
| 59 48,1,0,157,1,42,1,0,1,0,3,0,52,37,164,0,3,112,0,254,251,253,80,0 | |
| 60 }; | |
| 61 | |
| 62 static GURL kTestUrl = GURL("http://www.img.com"); | |
| 63 | |
| 64 } // namespace | |
| 65 | |
| 66 class ImageFetcherTest : public PlatformTest { | |
| 67 protected: | |
| 68 ImageFetcherTest() | |
| 69 : pool_(new base::SequencedWorkerPool(1, "TestPool")), | |
| 70 image_fetcher_(new image_fetcher::ImageFetcher(pool_)), | |
| 71 result_(nil), | |
| 72 called_(false) { | |
| 73 callback_.reset( | |
| 74 [^(const GURL& original_url, int http_response_code, NSData* data) { | |
| 75 result_ = [UIImage imageWithData:data]; | |
| 76 called_ = true; | |
| 77 } copy]); | |
| 78 image_fetcher_->SetRequestContextGetter( | |
| 79 new net::TestURLRequestContextGetter( | |
| 80 base::MessageLoopProxy::current())); | |
| 81 } | |
| 82 | |
| 83 ~ImageFetcherTest() override { pool_->Shutdown(); } | |
| 84 | |
| 85 net::TestURLFetcher* SetupFetcher() { | |
| 86 image_fetcher_->StartDownload(kTestUrl, callback_); | |
| 87 EXPECT_EQ(nil, result_); | |
| 88 EXPECT_EQ(false, called_); | |
| 89 net::TestURLFetcher* fetcher = factory_.GetFetcherByID(0); | |
| 90 DCHECK(fetcher); | |
| 91 DCHECK(fetcher->delegate()); | |
| 92 return fetcher; | |
| 93 } | |
| 94 | |
| 95 base::MessageLoop loop_; | |
| 96 base::mac::ScopedBlock<image_fetcher::Callback> callback_; | |
| 97 net::TestURLFetcherFactory factory_; | |
| 98 scoped_refptr<base::SequencedWorkerPool> pool_; | |
| 99 scoped_ptr<image_fetcher::ImageFetcher> image_fetcher_; | |
| 100 UIImage* result_; | |
| 101 bool called_; | |
| 102 }; | |
| 103 | |
| 104 TEST_F(ImageFetcherTest, TestError) { | |
| 105 net::TestURLFetcher* fetcher = SetupFetcher(); | |
| 106 fetcher->set_response_code(404); | |
| 107 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
| 108 EXPECT_EQ(nil, result_); | |
| 109 EXPECT_TRUE(called_); | |
| 110 } | |
| 111 | |
| 112 TEST_F(ImageFetcherTest, TestJpg) { | |
| 113 net::TestURLFetcher* fetcher = SetupFetcher(); | |
| 114 fetcher->set_response_code(200); | |
| 115 fetcher->SetResponseString(std::string((char*)jpgImage, sizeof(jpgImage))); | |
| 116 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
| 117 EXPECT_NE(nil, result_); | |
| 118 EXPECT_TRUE(called_); | |
| 119 } | |
| 120 | |
| 121 TEST_F(ImageFetcherTest, TestPng) { | |
| 122 net::TestURLFetcher* fetcher = SetupFetcher(); | |
| 123 fetcher->set_response_code(200); | |
| 124 fetcher->SetResponseString(std::string((char*)pngImage, sizeof(pngImage))); | |
| 125 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
| 126 EXPECT_NE(nil, result_); | |
| 127 EXPECT_TRUE(called_); | |
| 128 } | |
| 129 | |
| 130 TEST_F(ImageFetcherTest, TestGoodWebP) { | |
| 131 net::TestURLFetcher* fetcher = SetupFetcher(); | |
| 132 fetcher->set_response_code(200); | |
| 133 fetcher->SetResponseString(std::string((char*)webpImage, sizeof(webpImage))); | |
| 134 std::string kZero = std::string("\0", 1); | |
| 135 std::string header_string = std::string("HTTP/1.1 200 OK") + kZero + | |
| 136 "Content-type: image/webp" + kZero + kZero; | |
| 137 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders( | |
| 138 header_string)); | |
| 139 fetcher->set_response_headers(headers); | |
| 140 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
| 141 pool_->FlushForTesting(); | |
| 142 base::RunLoop().RunUntilIdle(); | |
| 143 EXPECT_NE(nil, result_); | |
| 144 EXPECT_TRUE(called_); | |
| 145 } | |
| 146 | |
| 147 TEST_F(ImageFetcherTest, TestBadWebP) { | |
| 148 net::TestURLFetcher* fetcher = SetupFetcher(); | |
| 149 fetcher->set_response_code(200); | |
| 150 fetcher->SetResponseString("This is not a valid WebP image"); | |
| 151 std::string kZero = std::string("\0", 1); | |
| 152 std::string header_string = std::string("HTTP/1.1 200 OK") + kZero + | |
| 153 "Content-type: image/webp" + kZero + kZero; | |
| 154 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders( | |
| 155 header_string)); | |
| 156 fetcher->set_response_headers(headers); | |
| 157 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
| 158 pool_->FlushForTesting(); | |
| 159 base::RunLoop().RunUntilIdle(); | |
| 160 EXPECT_EQ(nil, result_); | |
| 161 EXPECT_TRUE(called_); | |
| 162 } | |
| 163 | |
| 164 TEST_F(ImageFetcherTest, DeleteDuringWebPDecoding) { | |
| 165 net::TestURLFetcher* fetcher = SetupFetcher(); | |
| 166 fetcher->set_response_code(200); | |
| 167 fetcher->SetResponseString(std::string((char*)webpImage, sizeof(webpImage))); | |
| 168 std::string kZero = std::string("\0", 1); | |
| 169 std::string header_string = std::string("HTTP/1.1 200 OK") + kZero + | |
| 170 "Content-type: image/webp" + kZero + kZero; | |
| 171 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders( | |
| 172 header_string)); | |
| 173 fetcher->set_response_headers(headers); | |
| 174 fetcher->delegate()->OnURLFetchComplete(fetcher); | |
| 175 // Delete the image fetcher, and check that the callback is not called. | |
| 176 image_fetcher_.reset(); | |
| 177 pool_->FlushForTesting(); | |
| 178 base::RunLoop().RunUntilIdle(); | |
| 179 EXPECT_EQ(nil, result_); | |
| 180 EXPECT_FALSE(called_); | |
| 181 } | |
| 182 | |
| 183 TEST_F(ImageFetcherTest, TestCallbacksNotCalledDuringDeletion) { | |
| 184 image_fetcher_->StartDownload(kTestUrl, callback_); | |
| 185 image_fetcher_.reset(); | |
| 186 EXPECT_FALSE(called_); | |
| 187 } | |
| 188 | |
| OLD | NEW |