Actually hook up ServiceWorkerRegistration.showNotification()

Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/notifications/ServiceWorkerRegistrationNotifications.h"
 
+#include "bindings/core/v8/CallbackPromiseAdapter.h"
+#include "bindings/core/v8/ScriptPromiseResolver.h"
+#include "bindings/core/v8/V8ThrowException.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
+#include "modules/notifications/Notification.h"
 #include "modules/notifications/NotificationOptions.h"
 #include "platform/weborigin/KURL.h"
+#include "public/platform/Platform.h"
 #include "public/platform/WebNotificationData.h"
+#include "public/platform/WebNotificationManager.h"
+#include "public/platform/WebSerializedOrigin.h"
 
 namespace blink {
 
 ScriptPromise ServiceWorkerRegistrationNotifications::showNotification(ScriptState* scriptState, ServiceWorkerRegistration& serviceWorkerRegistration, const String& title, const NotificationOptions& options)

[Michael van Ouwerkerk, 2014/12/09 19:38:04]

Why can't ServiceWorkerRegistration& be const?

[Peter Beverloo, 2014/12/10 13:24:36]

Neither .active() nor .webRegistration() are defined as being const, or return
const types.

 {
+    ExecutionContext* executionContext = scriptState->executionContext();
+
+    // If context object's active worker is null, reject promise with a TypeError exception.
+    if (!serviceWorkerRegistration.active())
+        return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "No active registration available on the ServiceWorkerRegistration."));
+
+    // If permission for notification's origin is not "granted", reject promise with a TypeError exception, and terminate these substeps.
+    if (Notification::checkPermission(executionContext) != WebNotificationPermissionAllowed)
+        return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "No notification permission has been granted for this origin."));
+
+    RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

[Michael van Ouwerkerk, 2014/12/09 19:38:04]

Might want to keep an eye on this patch and resolve any conflict if it lands
first: https://codereview.chromium.org/783423003/

[Peter Beverloo, 2014/12/10 13:24:36]

Will do, thanks for the pointer!

+    ScriptPromise promise = resolver->promise();
+
+    // FIXME: Do the appropriate CORS checks on the icon URL.
+    // FIXME: Determine the text direction based on the options dictionary.
+
     KURL iconUrl;
     if (options.hasIcon() && !options.icon().isEmpty()) {
-        iconUrl = scriptState->executionContext()->completeURL(options.icon());
+        iconUrl = executionContext->completeURL(options.icon());
         if (!iconUrl.isValid())
             iconUrl = KURL();
     }
 
     WebNotificationData notification(title, WebNotificationData::DirectionLeftToRight, options.lang(), options.body(), options.tag(), iconUrl);
+    WebNotificationShowCallbacks* callbacks = new CallbackPromiseAdapter<void, void>(resolver);
 
-    // FIXME: Hook this up with the Blink API once it's been implemented.
-    return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError, "showNotification is not implemented yet."));
+    SecurityOrigin* origin = executionContext->securityOrigin();

[Michael van Ouwerkerk, 2014/12/09 19:38:04]

It would seem you don't need to pass the origin along, since you can read it
from the ServiceWorkerRegistration. No big deal though.

[Peter Beverloo, 2014/12/10 13:24:36]

Acknowledged. I'll opt for more three-sided clean-up patches later :-).

+    ASSERT(origin);
+
+    WebNotificationManager* notificationManager = Platform::current()->notificationManager();
+    ASSERT(notificationManager);
+
+    notificationManager->showPersistent(WebSerializedOrigin(*origin), notification, serviceWorkerRegistration.webRegistration(), callbacks);
+    return promise;
 }
 
 } // namespace blink