Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 787873003: Run "gn format" on v8's BUILD.gn file. (Closed)

Created:
5 years, 11 months ago by brettw
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Run "gn format" on v8's BUILD.gn file. There should be no functional change. This is a reland of a portion of https://codereview.chromium.org/834113005/ Committed: https://crrev.com/e1d957268d154e7fb7abd5a6cad54f602badc9b8 Cr-Commit-Position: refs/heads/master@{#25986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -134 lines) Patch
M BUILD.gn View 21 chunks +141 lines, -134 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
brettw
The previous patch was reverted for an error I don't understand. This is the "reformat" ...
5 years, 11 months ago (2015-01-08 08:53:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787873003/1
5 years, 11 months ago (2015-01-08 08:54:19 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-08 08:54:21 UTC) #5
brettw
Rerouting to machenbach since I think jochen is still slow and this should be straightforward ...
5 years, 11 months ago (2015-01-08 09:02:34 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-08 09:10:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787873003/1
5 years, 11 months ago (2015-01-08 09:10:30 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 09:35:24 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e1d957268d154e7fb7abd5a6cad54f602badc9b8 Cr-Commit-Position: refs/heads/master@{#25986}
5 years, 11 months ago (2015-01-08 09:35:40 UTC) #14
Michael Achenbach
5 years, 11 months ago (2015-01-08 10:47:13 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/793613003/ by machenbach@chromium.org.

The reason for reverting is: Need to revert in order to revert
https://codereview.chromium.org/832413005/.

Powered by Google App Engine
This is Rietveld 408576698