Issue 787833002: Revert of Replace EncodeBitmap with an interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 787833002: Revert of Replace EncodeBitmap with an interface. (Closed)

Created:
6 years ago by robertphillips

Modified:
6 years ago

Reviewers:
scroggo, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Replace EncodeBitmap with an interface. (patchset #11 id:190001 of https://codereview.chromium.org/784643002/) Reason for revert: Compilation is failing on some bots Original issue's description: > Replace EncodeBitmap with an interface. > > Gives more flexibility to the caller to decide whether to use the > encoded data returned by refEncodedData(). > > Provides an implementation that supports the old version of > SkPicture::serialize(). > > TODO: Update Chrome, so we can remove SK_LEGACY_ENCODE_BITMAP entirely > > BUG=skia:3190 > > Committed: https://skia.googlesource.com/skia/+/0c4aba6edb9900c597359dfa49d3ce4a41bc5dd1 TBR=reed@google.com,scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:3190 Committed: https://skia.googlesource.com/skia/+/c0708cb7bcc22a6ad14fc3c2198d8e00d71c6754

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -203 lines)			Patch
M	dm/DMSerializeTask.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/gmmain.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/skia_for_chromium_defines.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	include/core/SkPicture.h	View	3 chunks	+2 lines, -20 lines	0 comments	Download
D	include/core/SkPixelSerializer.h	View	1 chunk	+0 lines, -49 lines	0 comments	Download
M	include/core/SkWriteBuffer.h	View	3 chunks	+10 lines, -14 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	3 chunks	+3 lines, -36 lines	0 comments	Download
M	src/core/SkPictureData.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/core/SkPictureData.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/core/SkWriteBuffer.cpp	View	5 chunks	+31 lines, -38 lines	0 comments	Download
M	tests/PictureTest.cpp	View	3 chunks	+4 lines, -18 lines	0 comments	Download
M	tools/PictureRenderer.cpp	View	3 chunks	+5 lines, -19 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787833002/1

6 years ago (2014-12-09 13:34:56 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-09 13:35:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c0708cb7bcc22a6ad14fc3c2198d8e00d71c6754