Pull out a base class from DumpAccessibilityTree

Pull out a base class from DumpAccessibilityTree

This is in preparation for the following change that will add
DumpAccessibilityEvents tests, sharing a lot of common code.

BUG=440579
Committed: https://crrev.com/caade01bb15f31279e4452babfd625dff9c9a85e
Cr-Commit-Position: refs/heads/master@{#308760}

[dmazzoni, 2014-12-09 23:36:31]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2014-12-16 07:21:20]

Friendly ping

[David Tseng, 2014-12-17 01:03:32]

lgtm

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
File content/browser/accessibility/dump_accessibility_browsertest_base.cc
(right):

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_browsertest_base.cc:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
No (c) (and other instances).

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
File content/browser/accessibility/dump_accessibility_browsertest_base.h
(right):

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_browsertest_base.h:34: //
including the load complete accessibility event. The subclass should
Now that we test events, would we ever want to start event logging ebfore load
complete?

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_browsertest_base.h:40: //
should override this.
Since this method is pure virtual, this comment is unnecessary.

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_browsertest_base.h:46: virtual
void AdditionalErrorLogging() {}
Name of this method should reflect the comment more; maybe OnDiffFailed?

[dmazzoni, 2014-12-17 07:04:51]

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
File content/browser/accessibility/dump_accessibility_browsertest_base.cc
(right):

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_browsertest_base.cc:1: //
Copyright (c) 2014 The Chromium Authors. All rights reserved.
On 2014/12/17 01:03:32, David Tseng wrote:
> No (c) (and other instances).

Done.

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
File content/browser/accessibility/dump_accessibility_browsertest_base.h
(right):

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_browsertest_base.h:34: //
including the load complete accessibility event. The subclass should
On 2014/12/17 01:03:32, David Tseng wrote:
> Now that we test events, would we ever want to start event logging ebfore load
> complete?

Sure - not a super high priority for me right now but we could consider that
later.

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_browsertest_base.h:40: //
should override this.
On 2014/12/17 01:03:32, David Tseng wrote:
> Since this method is pure virtual, this comment is unnecessary.

Done.

https://codereview.chromium.org/787813006/diff/1/content/browser/accessibilit...
content/browser/accessibility/dump_accessibility_browsertest_base.h:46: virtual
void AdditionalErrorLogging() {}
On 2014/12/17 01:03:32, David Tseng wrote:
> Name of this method should reflect the comment more; maybe OnDiffFailed?

Done.

[dmazzoni, 2014-12-17 07:05:20]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-12-17 07:05:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787813006/20001

[dmazzoni, 2014-12-17 07:28:30]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-12-17 07:28:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787813006/40001

[commit-bot: I haz the power, 2014-12-17 08:28:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-17 08:29:18]

Patchset 3 (id:??) landed as
https://crrev.com/caade01bb15f31279e4452babfd625dff9c9a85e
Cr-Commit-Position: refs/heads/master@{#308760}