Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 787813004: Move ZoomController out of ChromeWebViewGuestDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build deps, address fsamuel@'s comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/guest_view_base.h" 5 #include "extensions/browser/guest_view/guest_view_base.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "components/ui/zoom/zoom_controller.h"
9 #include "content/public/browser/navigation_details.h" 10 #include "content/public/browser/navigation_details.h"
10 #include "content/public/browser/render_frame_host.h" 11 #include "content/public/browser/render_frame_host.h"
11 #include "content/public/browser/render_process_host.h" 12 #include "content/public/browser/render_process_host.h"
12 #include "content/public/browser/render_view_host.h" 13 #include "content/public/browser/render_view_host.h"
13 #include "content/public/browser/web_contents.h" 14 #include "content/public/browser/web_contents.h"
15 #include "content/public/common/page_zoom.h"
14 #include "content/public/common/url_constants.h" 16 #include "content/public/common/url_constants.h"
15 #include "extensions/browser/api/extensions_api_client.h" 17 #include "extensions/browser/api/extensions_api_client.h"
16 #include "extensions/browser/event_router.h" 18 #include "extensions/browser/event_router.h"
17 #include "extensions/browser/extension_registry.h" 19 #include "extensions/browser/extension_registry.h"
18 #include "extensions/browser/guest_view/app_view/app_view_guest.h" 20 #include "extensions/browser/guest_view/app_view/app_view_guest.h"
19 #include "extensions/browser/guest_view/extension_options/extension_options_gues t.h" 21 #include "extensions/browser/guest_view/extension_options/extension_options_gues t.h"
20 #include "extensions/browser/guest_view/guest_view_manager.h" 22 #include "extensions/browser/guest_view/guest_view_manager.h"
21 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_gues t.h" 23 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_gues t.h"
22 #include "extensions/browser/guest_view/web_view/web_view_guest.h" 24 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
23 #include "extensions/browser/process_map.h" 25 #include "extensions/browser/process_map.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 95
94 private: 96 private:
95 bool destroyed_; 97 bool destroyed_;
96 GuestViewBase* guest_; 98 GuestViewBase* guest_;
97 99
98 void Destroy() { 100 void Destroy() {
99 if (destroyed_) 101 if (destroyed_)
100 return; 102 return;
101 103
102 destroyed_ = true; 104 destroyed_ = true;
103 guest_->EmbedderWillBeDestroyed(); 105 guest_->OwnerWebContentsWillBeDestroyed();
104 guest_->owner_web_contents_ = NULL; 106 guest_->owner_web_contents_ = NULL;
105 guest_->Destroy(); 107 guest_->Destroy();
106 } 108 }
107 109
108 DISALLOW_COPY_AND_ASSIGN(OwnerLifetimeObserver); 110 DISALLOW_COPY_AND_ASSIGN(OwnerLifetimeObserver);
109 }; 111 };
110 112
111 // This observer ensures that the GuestViewBase destroys itself when its 113 // This observer ensures that the GuestViewBase destroys itself when its
112 // embedder goes away. 114 // embedder goes away.
113 class GuestViewBase::OpenerLifetimeObserver : public WebContentsObserver { 115 class GuestViewBase::OpenerLifetimeObserver : public WebContentsObserver {
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 owner_lifetime_observer_.reset( 204 owner_lifetime_observer_.reset(
203 new OwnerLifetimeObserver(this, owner_web_contents_)); 205 new OwnerLifetimeObserver(this, owner_web_contents_));
204 206
205 WebContentsObserver::Observe(guest_web_contents); 207 WebContentsObserver::Observe(guest_web_contents);
206 guest_web_contents->SetDelegate(this); 208 guest_web_contents->SetDelegate(this);
207 webcontents_guestview_map.Get().insert( 209 webcontents_guestview_map.Get().insert(
208 std::make_pair(guest_web_contents, this)); 210 std::make_pair(guest_web_contents, this));
209 GuestViewManager::FromBrowserContext(browser_context_)-> 211 GuestViewManager::FromBrowserContext(browser_context_)->
210 AddGuest(guest_instance_id_, guest_web_contents); 212 AddGuest(guest_instance_id_, guest_web_contents);
211 213
214 // Create a ZoomController to allow the guest's contents to be zoomed.
215 ui_zoom::ZoomController::CreateForWebContents(guest_web_contents);
216
212 // Give the derived class an opportunity to perform additional initialization. 217 // Give the derived class an opportunity to perform additional initialization.
213 DidInitialize(); 218 DidInitialize();
214 } 219 }
215 220
216 void GuestViewBase::SetAutoSize(bool enabled, 221 void GuestViewBase::SetAutoSize(bool enabled,
217 const gfx::Size& min_size, 222 const gfx::Size& min_size,
218 const gfx::Size& max_size) { 223 const gfx::Size& max_size) {
219 min_auto_size_ = min_size; 224 min_auto_size_ = min_size;
220 min_auto_size_.SetToMin(max_size); 225 min_auto_size_.SetToMin(max_size);
221 max_auto_size_ = max_size; 226 max_auto_size_ = max_size;
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 return false; 307 return false;
303 } 308 }
304 309
305 bool GuestViewBase::IsDragAndDropEnabled() const { 310 bool GuestViewBase::IsDragAndDropEnabled() const {
306 return false; 311 return false;
307 } 312 }
308 313
309 void GuestViewBase::DidAttach(int guest_proxy_routing_id) { 314 void GuestViewBase::DidAttach(int guest_proxy_routing_id) {
310 opener_lifetime_observer_.reset(); 315 opener_lifetime_observer_.reset();
311 316
317 // Any zoom events from the embedder should be relayed to the guest.
318 ui_zoom::ZoomController* zoom_controller =
319 ui_zoom::ZoomController::FromWebContents(embedder_web_contents());
320 if (zoom_controller) {
321 // Listen to the embedder's zoom changes.
322 zoom_controller->AddObserver(this);
323 // Set the guest's initial zoom level to be equal to the embedder's.
324 ui_zoom::ZoomController::FromWebContents(web_contents())
325 ->SetZoomLevel(zoom_controller->GetZoomLevel());
326 }
327
312 // Give the derived class an opportunity to perform some actions. 328 // Give the derived class an opportunity to perform some actions.
313 DidAttachToEmbedder(); 329 DidAttachToEmbedder();
314 330
315 // Inform the associated GuestViewContainer that the contentWindow is ready. 331 // Inform the associated GuestViewContainer that the contentWindow is ready.
316 embedder_web_contents()->Send(new ExtensionMsg_GuestAttached( 332 embedder_web_contents()->Send(new ExtensionMsg_GuestAttached(
317 embedder_web_contents()->GetMainFrame()->GetRoutingID(), 333 embedder_web_contents()->GetMainFrame()->GetRoutingID(),
318 element_instance_id_, 334 element_instance_id_,
319 guest_proxy_routing_id)); 335 guest_proxy_routing_id));
320 336
321 SendQueuedEvents(); 337 SendQueuedEvents();
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 bool GuestViewBase::PreHandleGestureEvent(content::WebContents* source, 494 bool GuestViewBase::PreHandleGestureEvent(content::WebContents* source,
479 const blink::WebGestureEvent& event) { 495 const blink::WebGestureEvent& event) {
480 return event.type == blink::WebGestureEvent::GesturePinchBegin || 496 return event.type == blink::WebGestureEvent::GesturePinchBegin ||
481 event.type == blink::WebGestureEvent::GesturePinchUpdate || 497 event.type == blink::WebGestureEvent::GesturePinchUpdate ||
482 event.type == blink::WebGestureEvent::GesturePinchEnd; 498 event.type == blink::WebGestureEvent::GesturePinchEnd;
483 } 499 }
484 500
485 GuestViewBase::~GuestViewBase() { 501 GuestViewBase::~GuestViewBase() {
486 } 502 }
487 503
504 void GuestViewBase::OnZoomChanged(
505 const ui_zoom::ZoomController::ZoomChangedEventData& data) {
506 if (content::ZoomValuesEqual(data.old_zoom_level, data.new_zoom_level))
507 return;
508
509 // When the embedder's zoom level is changed, then we also update the
510 // guest's zoom level to match.
511 ui_zoom::ZoomController::FromWebContents(web_contents())
512 ->SetZoomLevel(data.new_zoom_level);
513 }
514
488 void GuestViewBase::DispatchEventToEmbedder(Event* event) { 515 void GuestViewBase::DispatchEventToEmbedder(Event* event) {
489 scoped_ptr<Event> event_ptr(event); 516 scoped_ptr<Event> event_ptr(event);
490 517
491 if (!attached()) { 518 if (!attached()) {
492 pending_events_.push_back(linked_ptr<Event>(event_ptr.release())); 519 pending_events_.push_back(linked_ptr<Event>(event_ptr.release()));
493 return; 520 return;
494 } 521 }
495 522
496 EventFilteringInfo info; 523 EventFilteringInfo info;
497 info.SetInstanceID(view_instance_id_); 524 info.SetInstanceID(view_instance_id_);
(...skipping 27 matching lines...) Expand all
525 // The derived class did not create a WebContents so this class serves no 552 // The derived class did not create a WebContents so this class serves no
526 // purpose. Let's self-destruct. 553 // purpose. Let's self-destruct.
527 delete this; 554 delete this;
528 callback.Run(NULL); 555 callback.Run(NULL);
529 return; 556 return;
530 } 557 }
531 InitWithWebContents(owner_extension_id, guest_web_contents); 558 InitWithWebContents(owner_extension_id, guest_web_contents);
532 callback.Run(guest_web_contents); 559 callback.Run(guest_web_contents);
533 } 560 }
534 561
562 void GuestViewBase::OwnerWebContentsWillBeDestroyed() {
563 ui_zoom::ZoomController* zoom_controller =
564 ui_zoom::ZoomController::FromWebContents(embedder_web_contents());
565 if (zoom_controller)
566 zoom_controller->RemoveObserver(this);
567
568 EmbedderWillBeDestroyed();
569 }
570
535 // static 571 // static
536 void GuestViewBase::RegisterGuestViewTypes() { 572 void GuestViewBase::RegisterGuestViewTypes() {
537 AppViewGuest::Register(); 573 AppViewGuest::Register();
538 ExtensionOptionsGuest::Register(); 574 ExtensionOptionsGuest::Register();
539 MimeHandlerViewGuest::Register(); 575 MimeHandlerViewGuest::Register();
540 WebViewGuest::Register(); 576 WebViewGuest::Register();
541 } 577 }
542 578
543 } // namespace extensions 579 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698