Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 787813004: Move ZoomController out of ChromeWebViewGuestDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix incorrect wording in comment. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/guest_view_base.h" 5 #include "extensions/browser/guest_view/guest_view_base.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "components/ui/zoom/zoom_controller.h"
9 #include "content/public/browser/navigation_details.h" 10 #include "content/public/browser/navigation_details.h"
10 #include "content/public/browser/render_frame_host.h" 11 #include "content/public/browser/render_frame_host.h"
11 #include "content/public/browser/render_process_host.h" 12 #include "content/public/browser/render_process_host.h"
12 #include "content/public/browser/render_view_host.h" 13 #include "content/public/browser/render_view_host.h"
13 #include "content/public/browser/web_contents.h" 14 #include "content/public/browser/web_contents.h"
15 #include "content/public/common/page_zoom.h"
14 #include "content/public/common/url_constants.h" 16 #include "content/public/common/url_constants.h"
15 #include "extensions/browser/api/extensions_api_client.h" 17 #include "extensions/browser/api/extensions_api_client.h"
16 #include "extensions/browser/event_router.h" 18 #include "extensions/browser/event_router.h"
17 #include "extensions/browser/extension_registry.h" 19 #include "extensions/browser/extension_registry.h"
18 #include "extensions/browser/guest_view/app_view/app_view_guest.h" 20 #include "extensions/browser/guest_view/app_view/app_view_guest.h"
19 #include "extensions/browser/guest_view/extension_options/extension_options_gues t.h" 21 #include "extensions/browser/guest_view/extension_options/extension_options_gues t.h"
20 #include "extensions/browser/guest_view/guest_view_manager.h" 22 #include "extensions/browser/guest_view/guest_view_manager.h"
21 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_gues t.h" 23 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_view_gues t.h"
22 #include "extensions/browser/guest_view/web_view/web_view_guest.h" 24 #include "extensions/browser/guest_view/web_view/web_view_guest.h"
23 #include "extensions/browser/guest_view/worker_frame/worker_frame_guest.h" 25 #include "extensions/browser/guest_view/worker_frame/worker_frame_guest.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 private: 97 private:
96 bool destroyed_; 98 bool destroyed_;
97 GuestViewBase* guest_; 99 GuestViewBase* guest_;
98 100
99 void Destroy() { 101 void Destroy() {
100 if (destroyed_) 102 if (destroyed_)
101 return; 103 return;
102 104
103 destroyed_ = true; 105 destroyed_ = true;
104 guest_->EmbedderWillBeDestroyed(); 106 guest_->EmbedderWillBeDestroyed();
105 guest_->owner_web_contents_ = NULL;
106 guest_->Destroy(); 107 guest_->Destroy();
107 } 108 }
108 109
109 DISALLOW_COPY_AND_ASSIGN(OwnerLifetimeObserver); 110 DISALLOW_COPY_AND_ASSIGN(OwnerLifetimeObserver);
110 }; 111 };
111 112
112 // This observer ensures that the GuestViewBase destroys itself when its 113 // This observer ensures that the GuestViewBase destroys itself when its
113 // embedder goes away. 114 // embedder goes away.
114 class GuestViewBase::OpenerLifetimeObserver : public WebContentsObserver { 115 class GuestViewBase::OpenerLifetimeObserver : public WebContentsObserver {
115 public: 116 public:
(...skipping 23 matching lines...) Expand all
139 int guest_instance_id) 140 int guest_instance_id)
140 : owner_web_contents_(owner_web_contents), 141 : owner_web_contents_(owner_web_contents),
141 browser_context_(browser_context), 142 browser_context_(browser_context),
142 guest_instance_id_(guest_instance_id), 143 guest_instance_id_(guest_instance_id),
143 view_instance_id_(guestview::kInstanceIDNone), 144 view_instance_id_(guestview::kInstanceIDNone),
144 element_instance_id_(guestview::kInstanceIDNone), 145 element_instance_id_(guestview::kInstanceIDNone),
145 initialized_(false), 146 initialized_(false),
146 is_being_destroyed_(false), 147 is_being_destroyed_(false),
147 auto_size_enabled_(false), 148 auto_size_enabled_(false),
148 is_full_page_plugin_(false), 149 is_full_page_plugin_(false),
150 observing_owners_zoom_controller_(false),
149 weak_ptr_factory_(this) { 151 weak_ptr_factory_(this) {
150 } 152 }
151 153
152 void GuestViewBase::Init(const std::string& owner_extension_id, 154 void GuestViewBase::Init(const std::string& owner_extension_id,
153 const base::DictionaryValue& create_params, 155 const base::DictionaryValue& create_params,
154 const WebContentsCreatedCallback& callback) { 156 const WebContentsCreatedCallback& callback) {
155 if (initialized_) 157 if (initialized_)
156 return; 158 return;
157 initialized_ = true; 159 initialized_ = true;
158 160
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 owner_lifetime_observer_.reset( 204 owner_lifetime_observer_.reset(
203 new OwnerLifetimeObserver(this, owner_web_contents_)); 205 new OwnerLifetimeObserver(this, owner_web_contents_));
204 206
205 WebContentsObserver::Observe(guest_web_contents); 207 WebContentsObserver::Observe(guest_web_contents);
206 guest_web_contents->SetDelegate(this); 208 guest_web_contents->SetDelegate(this);
207 webcontents_guestview_map.Get().insert( 209 webcontents_guestview_map.Get().insert(
208 std::make_pair(guest_web_contents, this)); 210 std::make_pair(guest_web_contents, this));
209 GuestViewManager::FromBrowserContext(browser_context_)-> 211 GuestViewManager::FromBrowserContext(browser_context_)->
210 AddGuest(guest_instance_id_, guest_web_contents); 212 AddGuest(guest_instance_id_, guest_web_contents);
211 213
214 // Create a ZoomController to allow the guest's contents to be zoomed.
215 ui_zoom::ZoomController::CreateForWebContents(guest_web_contents);
216
212 // Give the derived class an opportunity to perform additional initialization. 217 // Give the derived class an opportunity to perform additional initialization.
213 DidInitialize(); 218 DidInitialize();
214 } 219 }
215 220
216 void GuestViewBase::SetAutoSize(bool enabled, 221 void GuestViewBase::SetAutoSize(bool enabled,
217 const gfx::Size& min_size, 222 const gfx::Size& min_size,
218 const gfx::Size& max_size) { 223 const gfx::Size& max_size) {
219 min_auto_size_ = min_size; 224 min_auto_size_ = min_size;
220 min_auto_size_.SetToMin(max_size); 225 min_auto_size_.SetToMin(max_size);
221 max_auto_size_ = max_size; 226 max_auto_size_ = max_size;
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 return false; 307 return false;
303 } 308 }
304 309
305 bool GuestViewBase::IsDragAndDropEnabled() const { 310 bool GuestViewBase::IsDragAndDropEnabled() const {
306 return false; 311 return false;
307 } 312 }
308 313
309 void GuestViewBase::DidAttach(int guest_proxy_routing_id) { 314 void GuestViewBase::DidAttach(int guest_proxy_routing_id) {
310 opener_lifetime_observer_.reset(); 315 opener_lifetime_observer_.reset();
311 316
317 // Any zoom events from the embedder should be relayed to the guest.
318 StartObservingOwnersZoomController();
319
312 // Give the derived class an opportunity to perform some actions. 320 // Give the derived class an opportunity to perform some actions.
313 DidAttachToEmbedder(); 321 DidAttachToEmbedder();
314 322
315 // Inform the associated GuestViewContainer that the contentWindow is ready. 323 // Inform the associated GuestViewContainer that the contentWindow is ready.
316 embedder_web_contents()->Send(new ExtensionMsg_GuestAttached( 324 embedder_web_contents()->Send(new ExtensionMsg_GuestAttached(
317 embedder_web_contents()->GetMainFrame()->GetRoutingID(), 325 embedder_web_contents()->GetMainFrame()->GetRoutingID(),
318 element_instance_id_, 326 element_instance_id_,
319 guest_proxy_routing_id)); 327 guest_proxy_routing_id));
320 328
321 SendQueuedEvents(); 329 SendQueuedEvents();
(...skipping 28 matching lines...) Expand all
350 const GURL& GuestViewBase::GetOwnerSiteURL() const { 358 const GURL& GuestViewBase::GetOwnerSiteURL() const {
351 return owner_web_contents()->GetLastCommittedURL(); 359 return owner_web_contents()->GetLastCommittedURL();
352 } 360 }
353 361
354 void GuestViewBase::Destroy() { 362 void GuestViewBase::Destroy() {
355 if (is_being_destroyed_) 363 if (is_being_destroyed_)
356 return; 364 return;
357 365
358 is_being_destroyed_ = true; 366 is_being_destroyed_ = true;
359 367
368 // It is important to clear owner_web_contents_ after the call to
369 // StopObservingOwnersZoomControllerIfNecessary(), but before the rest of
370 // the statements in this function.
371 StopObservingOwnersZoomControllerIfNecessary();
372 owner_web_contents_ = NULL;
373
360 DCHECK(web_contents()); 374 DCHECK(web_contents());
361 375
362 // Give the derived class an opportunity to perform some cleanup. 376 // Give the derived class an opportunity to perform some cleanup.
363 WillDestroy(); 377 WillDestroy();
364 378
365 // Invalidate weak pointers now so that bound callbacks cannot be called late 379 // Invalidate weak pointers now so that bound callbacks cannot be called late
366 // into destruction. We must call this after WillDestroy because derived types 380 // into destruction. We must call this after WillDestroy because derived types
367 // may wish to access their openers. 381 // may wish to access their openers.
368 weak_ptr_factory_.InvalidateWeakPtrs(); 382 weak_ptr_factory_.InvalidateWeakPtrs();
369 383
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 bool GuestViewBase::PreHandleGestureEvent(content::WebContents* source, 492 bool GuestViewBase::PreHandleGestureEvent(content::WebContents* source,
479 const blink::WebGestureEvent& event) { 493 const blink::WebGestureEvent& event) {
480 return event.type == blink::WebGestureEvent::GesturePinchBegin || 494 return event.type == blink::WebGestureEvent::GesturePinchBegin ||
481 event.type == blink::WebGestureEvent::GesturePinchUpdate || 495 event.type == blink::WebGestureEvent::GesturePinchUpdate ||
482 event.type == blink::WebGestureEvent::GesturePinchEnd; 496 event.type == blink::WebGestureEvent::GesturePinchEnd;
483 } 497 }
484 498
485 GuestViewBase::~GuestViewBase() { 499 GuestViewBase::~GuestViewBase() {
486 } 500 }
487 501
502 void GuestViewBase::OnZoomChanged(
503 const ui_zoom::ZoomController::ZoomChangedEventData& data) {
504 if (content::ZoomValuesEqual(data.old_zoom_level, data.new_zoom_level))
505 return;
506
507 // When the embedder's zoom level is changed, then we also update the
508 // guest's zoom level to match.
509 ui_zoom::ZoomController::FromWebContents(web_contents())
510 ->SetZoomLevel(data.new_zoom_level);
511 }
512
488 void GuestViewBase::DispatchEventToEmbedder(Event* event) { 513 void GuestViewBase::DispatchEventToEmbedder(Event* event) {
489 scoped_ptr<Event> event_ptr(event); 514 scoped_ptr<Event> event_ptr(event);
490 515
491 if (!attached()) { 516 if (!attached()) {
492 pending_events_.push_back(linked_ptr<Event>(event_ptr.release())); 517 pending_events_.push_back(linked_ptr<Event>(event_ptr.release()));
493 return; 518 return;
494 } 519 }
495 520
496 EventFilteringInfo info; 521 EventFilteringInfo info;
497 info.SetInstanceID(view_instance_id_); 522 info.SetInstanceID(view_instance_id_);
(...skipping 27 matching lines...) Expand all
525 // The derived class did not create a WebContents so this class serves no 550 // The derived class did not create a WebContents so this class serves no
526 // purpose. Let's self-destruct. 551 // purpose. Let's self-destruct.
527 delete this; 552 delete this;
528 callback.Run(NULL); 553 callback.Run(NULL);
529 return; 554 return;
530 } 555 }
531 InitWithWebContents(owner_extension_id, guest_web_contents); 556 InitWithWebContents(owner_extension_id, guest_web_contents);
532 callback.Run(guest_web_contents); 557 callback.Run(guest_web_contents);
533 } 558 }
534 559
560 void GuestViewBase::StartObservingOwnersZoomController() {
561 ui_zoom::ZoomController* zoom_controller =
562 ui_zoom::ZoomController::FromWebContents(embedder_web_contents());
563 if (!zoom_controller)
564 return;
565
566 // Listen to the embedder's zoom changes.
567 zoom_controller->AddObserver(this);
568 observing_owners_zoom_controller_ = true;
569 // Set the guest's initial zoom level to be equal to the embedder's.
570 ui_zoom::ZoomController::FromWebContents(web_contents())
571 ->SetZoomLevel(zoom_controller->GetZoomLevel());
572 }
573
574 void GuestViewBase::StopObservingOwnersZoomControllerIfNecessary() {
575 // We use owner_web_contents_ below and not embedder_web_contents() since
576 // we may have been detached by this point.
577 DCHECK(!observing_owners_zoom_controller_ || owner_web_contents_);
578 if (!owner_web_contents_ || !observing_owners_zoom_controller_)
579 return;
580
581 ui_zoom::ZoomController* zoom_controller =
582 ui_zoom::ZoomController::FromWebContents(owner_web_contents_);
583 zoom_controller->RemoveObserver(this);
584 observing_owners_zoom_controller_ = false;
585 }
586
535 // static 587 // static
536 void GuestViewBase::RegisterGuestViewTypes() { 588 void GuestViewBase::RegisterGuestViewTypes() {
537 AppViewGuest::Register(); 589 AppViewGuest::Register();
538 ExtensionOptionsGuest::Register(); 590 ExtensionOptionsGuest::Register();
539 MimeHandlerViewGuest::Register(); 591 MimeHandlerViewGuest::Register();
540 WebViewGuest::Register(); 592 WebViewGuest::Register();
541 WorkerFrameGuest::Register(); 593 WorkerFrameGuest::Register();
542 } 594 }
543 595
544 } // namespace extensions 596 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/guest_view/guest_view_base.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698