Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(31)

Issue 7878009: Merge 94988 - REGRESSION: Moving up doesn't work in some cases (Closed)

Created:
8 years, 11 months ago by rniwa-cr
Modified:
8 years, 11 months ago
Reviewers:
rniwa
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94988 - REGRESSION: Moving up doesn't work in some cases https://bugs.webkit.org/show_bug.cgi?id=67522 Reviewed by Eric Seidel. Source/WebCore: The bug was caused by previousLinePosition's attempting to obtain the last root line box using a position at minCaretOffset (which is, in practice, located at the beginning of wrapped lines). Fix the bug by calling maxCaretOffset instead. Because isCandidate returns false at (br, 1), use the positionBeforeNode for br elements. Test: editing/selection/move-up-into-wrapped-line.html * editing/visible_units.cpp: (WebCore::previousLinePosition): LayoutTests: Add a test to move caret upwards from an empty line below wrapped lines. WebKit used to skip wrapped lines and placed caret at the beginning of the first of those wrapped lines instead of before the last. * editing/selection/move-up-into-wrapped-line-expected.txt: Added. * editing/selection/move-up-into-wrapped-line.html: Added. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + LayoutTests/editing/selection/move-up-into-wrapped-line.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/selection/move-up-into-wrapped-line-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/editing/visible_units.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
rniwa-cr
8 years, 11 months ago (2011-09-13 00:25:34 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698