Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 787793002: [ServiceWorker] Add contentType argument to BodyStreamBuffer::readAllAndCreateBlobHandle. (Closed)

Created:
6 years ago by horo
Modified:
6 years ago
Reviewers:
yhirano
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add contentType argument to BodyStreamBuffer::readAllAndCreateBlobHandle. We can set the contentType of the blob data, but we can't change the contentType of the blob handle. So we have to set the contentType when calling BodyStreamBuffer::readAllAndCreateBlobHandle. BUG=436424 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186942

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add contentType argument to BodyStreamBuffer::readAllAndCreateBlobHandle #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M Source/modules/serviceworkers/BodyStreamBuffer.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/BodyStreamBuffer.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/BodyStreamBufferTest.cpp View 1 6 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
horo
yhirano@ Could you please review?
6 years ago (2014-12-09 09:30:01 UTC) #5
yhirano
https://codereview.chromium.org/787793002/diff/60001/Source/modules/serviceworkers/BodyStreamBuffer.h File Source/modules/serviceworkers/BodyStreamBuffer.h (right): https://codereview.chromium.org/787793002/diff/60001/Source/modules/serviceworkers/BodyStreamBuffer.h#newcode36 Source/modules/serviceworkers/BodyStreamBuffer.h:36: explicit BodyStreamBuffer(const String& contentType); The specified content type takes ...
6 years ago (2014-12-11 03:44:18 UTC) #6
horo
https://codereview.chromium.org/787793002/diff/60001/Source/modules/serviceworkers/BodyStreamBuffer.h File Source/modules/serviceworkers/BodyStreamBuffer.h (right): https://codereview.chromium.org/787793002/diff/60001/Source/modules/serviceworkers/BodyStreamBuffer.h#newcode36 Source/modules/serviceworkers/BodyStreamBuffer.h:36: explicit BodyStreamBuffer(const String& contentType); On 2014/12/11 03:44:18, yhirano wrote: ...
6 years ago (2014-12-11 04:48:56 UTC) #7
yhirano
lgtm https://codereview.chromium.org/787793002/diff/80001/Source/modules/serviceworkers/BodyStreamBuffer.h File Source/modules/serviceworkers/BodyStreamBuffer.h (right): https://codereview.chromium.org/787793002/diff/80001/Source/modules/serviceworkers/BodyStreamBuffer.h#newcode53 Source/modules/serviceworkers/BodyStreamBuffer.h:53: bool readAllAndCreateBlobHandle(const String& /* contentType */, BlobHandleCreatorClient*); You ...
6 years ago (2014-12-11 04:52:59 UTC) #8
horo
https://codereview.chromium.org/787793002/diff/80001/Source/modules/serviceworkers/BodyStreamBuffer.h File Source/modules/serviceworkers/BodyStreamBuffer.h (right): https://codereview.chromium.org/787793002/diff/80001/Source/modules/serviceworkers/BodyStreamBuffer.h#newcode53 Source/modules/serviceworkers/BodyStreamBuffer.h:53: bool readAllAndCreateBlobHandle(const String& /* contentType */, BlobHandleCreatorClient*); On 2014/12/11 ...
6 years ago (2014-12-11 05:45:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787793002/100001
6 years ago (2014-12-11 06:40:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/40846)
6 years ago (2014-12-11 08:32:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787793002/100001
6 years ago (2014-12-11 10:03:47 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-11 11:34:08 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186942

Powered by Google App Engine
This is Rietveld 408576698