Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 787763007: extract cubic classification from gpu into geometry (Closed)

Created:
6 years ago by caryclark
Modified:
6 years ago
Reviewers:
egdaniel, bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Extract cubic classification from gpu into geometry Move code from the GPU path utilities into geometry so that path ops can share. Committed: https://skia.googlesource.com/skia/+/8dd31cf69e24ff82865309781107dfab948b6a02

Patch Set 1 #

Patch Set 2 : fix accidental change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -87 lines) Patch
M src/core/SkGeometry.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/core/SkGeometry.cpp View 1 chunk +69 lines, -0 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 5 chunks +11 lines, -87 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caryclark
6 years ago (2014-12-12 16:35:12 UTC) #2
bsalomon
lgtm
6 years ago (2014-12-12 16:40:50 UTC) #3
reed1
lgtm
6 years ago (2014-12-12 16:42:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787763007/20001
6 years ago (2014-12-12 17:01:09 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 17:11:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8dd31cf69e24ff82865309781107dfab948b6a02

Powered by Google App Engine
This is Rietveld 408576698