Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3955)

Unified Diff: cc/trees/single_thread_proxy.cc

Issue 787763006: cc: Adding BeginFrameTracker object and removing Now() from LTHI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing gn bots. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/single_thread_proxy.cc
diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_proxy.cc
index 6498f0e0996ce49b310eb9a1c7a5d83bcfbfe4df..dd6f7b4a50d3df75c7d22b720849e2ee39dbee82 100644
--- a/cc/trees/single_thread_proxy.cc
+++ b/cc/trees/single_thread_proxy.cc
@@ -494,6 +494,7 @@ void SingleThreadProxy::CompositeImmediately(base::TimeTicks frame_begin_time) {
BeginFrameArgs begin_frame_args(BeginFrameArgs::Create(
BEGINFRAME_FROM_HERE, frame_begin_time, base::TimeTicks(),
BeginFrameArgs::DefaultInterval(), BeginFrameArgs::SYNCHRONOUS));
+ layer_tree_host_impl_->UpdateCurrentBeginFrameArgs(begin_frame_args);
DoBeginMainFrame(begin_frame_args);
DoCommit();
@@ -519,6 +520,8 @@ void SingleThreadProxy::CompositeImmediately(base::TimeTicks frame_begin_time) {
// another draw will never be scheduled, so break remaining promises.
layer_tree_host_impl_->active_tree()->BreakSwapPromises(
SwapPromise::SWAP_FAILS);
+
+ layer_tree_host_impl_->ResetCurrentBeginFrameArgsForNextFrame();
}
}
@@ -593,7 +596,6 @@ DrawResult SingleThreadProxy::DoComposite(base::TimeTicks frame_begin_time,
bool start_ready_animations = draw_frame;
layer_tree_host_impl_->UpdateAnimationState(start_ready_animations);
- layer_tree_host_impl_->ResetCurrentBeginFrameArgsForNextFrame();
brianderson 2014/12/18 02:01:38 Why does this need to move?
mithro-old 2014/12/18 17:22:41 Because it's currently in the wrong place as code
timing_history_.DidFinishDrawing();
}
« cc/trees/layer_tree_host_unittest_context.cc ('K') | « cc/trees/layer_tree_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698