Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 787763005: Ensure class prototype objects have the right Map::constructor field (Closed)

Created:
6 years ago by adamk
Modified:
6 years ago
CC:
v8-dev, esprehn
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Ensure class prototype objects have the right Map::constructor field The null constructor they had previously could be observed as crashes in the V8 API's Object::CreationContext() method and in Object.observe. BUG=v8:3750 LOG=n R=arv@chromium.org, dslomov@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/986e7cefe13cbfe84649768c26295fed307ae97c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M src/runtime/runtime-classes.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-3750.js View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
adamk
6 years ago (2014-12-09 23:03:52 UTC) #2
Dmitry Lomov (no reviews)
lgtm
6 years ago (2014-12-09 23:05:07 UTC) #3
arv (Not doing code reviews)
LGTM
6 years ago (2014-12-09 23:27:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787763005/1
6 years ago (2014-12-10 16:25:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/393) v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/419) v8_win64_rel ...
6 years ago (2014-12-10 16:26:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787763005/1
6 years ago (2014-12-10 18:21:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/381) v8_linux64_asan_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/397) v8_linux_arm_rel ...
6 years ago (2014-12-10 18:22:18 UTC) #12
adamk
6 years ago (2014-12-10 18:26:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
986e7cefe13cbfe84649768c26295fed307ae97c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698