Issue 78773006: CQ: catch more errors (IOError in this case, mostly for socket errors).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78773006: CQ: catch more errors (IOError in this case, mostly for socket errors). (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.

Modified:
7 years, 1 month ago

Reviewers:
iannucci

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

More Reviews

Description

CQ: catch more errors (IOError in this case, mostly for socket errors). Note that while some errors are indeed socket.error, sometimes we get IOError which is a superclass of socket.error so just catching that makes the code simpler. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=236367

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	commit-queue/verification/tree_status.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/78773006/1

7 years, 1 month ago (2013-11-21 01:21:40 UTC) #3

Message was sent while issue was closed.

Change committed as 236367

Expand Messages | Collapse Messages