Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 787713002: Fix GrUnPreMulColor. (Closed)

Created:
6 years ago by egdaniel
Modified:
6 years ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix GrUnPreMulColor. Current version incorrectly unpacked the resulting sk unpremulled color into rgba. BUG=skia:3208 Committed: https://skia.googlesource.com/skia/+/4ccf0b94054a4c16641c027edb4b0cfd0daddb65

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/gpu/GrColor.h View 1 chunk +4 lines, -4 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
egdaniel
This is to fix currently breaking mac test bots
6 years ago (2014-12-08 20:17:53 UTC) #2
reed1
lgtm why do we have SkColor AND GrColor?
6 years ago (2014-12-08 20:18:57 UTC) #3
bsalomon
https://codereview.chromium.org/787713002/diff/1/include/gpu/GrColor.h File include/gpu/GrColor.h (right): https://codereview.chromium.org/787713002/diff/1/include/gpu/GrColor.h#newcode114 include/gpu/GrColor.h:114: r = SkColorGetR(colorUPM); GrColorUnpackR, etc?
6 years ago (2014-12-08 20:19:33 UTC) #4
bsalomon
https://codereview.chromium.org/787713002/diff/1/include/gpu/GrColor.h File include/gpu/GrColor.h (right): https://codereview.chromium.org/787713002/diff/1/include/gpu/GrColor.h#newcode114 include/gpu/GrColor.h:114: r = SkColorGetR(colorUPM); On 2014/12/08 20:19:32, bsalomon wrote: > ...
6 years ago (2014-12-08 20:21:19 UTC) #5
bsalomon
On 2014/12/08 20:18:57, reed1 wrote: > lgtm > > why do we have SkColor AND ...
6 years ago (2014-12-08 20:21:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787713002/1
6 years ago (2014-12-08 20:31:12 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-08 20:35:21 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4ccf0b94054a4c16641c027edb4b0cfd0daddb65

Powered by Google App Engine
This is Rietveld 408576698