Issue 787693003: Use the showContextMenuOnMouseUp setting instead of #ifdef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 787693003: Use the showContextMenuOnMouseUp setting instead of #ifdef. (Closed)

Created:
6 years ago by zino

Modified:
6 years ago

Reviewers:
Rick Byers

CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Use the showContextMenuOnMouseUp setting instead of #ifdef. It is better to use the showContextMenuOnMouseUp setting[1] instead of #ifdef. [1] The setting has already been added from https://crrev.com/776483002. BUG=438544 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186827

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	Source/core/page/EventHandler.cpp	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Total messages: 6 (2 generated)

Rick Byers

lgtm This is a trivial enough change following the existing pattern that I'm OK not ...

6 years ago (2014-12-09 21:20:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787693003/1

6 years ago (2014-12-10 00:12:15 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-10 03:15:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186827