Move PolicyMap and its dependencies to components/policy/.

Move PolicyMap and its dependencies to components/policy/.

This facilitates the refactoring of chrome/browser/policy into a layered
component.

BUG=271392
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236575

[dconnelly, 2013-11-20 16:19:31]

joao for sanity check
jochen for mass-renaming

[jochen (gone - plz use gerrit), 2013-11-21 13:55:24]

one general question.

You're moving files from browser/ to common/

is this really intended? Are you going to include the headers from a
non-browser/ location?

https://codereview.chromium.org/78763002/diff/1/components/policy/core/common...
File components/policy/core/common/external_data_manager.h (right):

https://codereview.chromium.org/78763002/diff/1/components/policy/core/common...
components/policy/core/common/external_data_manager.h:20: class POLICY_EXPORT
ExternalDataManager {
you don't need to export pure virtual interfaces

[dconnelly, 2013-11-21 13:57:56]

On 2013/11/21 13:55:24, jochen wrote:
> one general question.
> 
> You're moving files from browser/ to common/
> 
> is this really intended? Are you going to include the headers from a
> non-browser/ location?

Yes -- for iOS. I don't think everything I move will be into common/, but most
of it will.

> 
>
https://codereview.chromium.org/78763002/diff/1/components/policy/core/common...
> File components/policy/core/common/external_data_manager.h (right):
> 
>
https://codereview.chromium.org/78763002/diff/1/components/policy/core/common...
> components/policy/core/common/external_data_manager.h:20: class POLICY_EXPORT
> ExternalDataManager {
> you don't need to export pure virtual interfaces

[dconnelly, 2013-11-21 14:04:22]

https://codereview.chromium.org/78763002/diff/1/components/policy/core/common...
File components/policy/core/common/external_data_manager.h (right):

https://codereview.chromium.org/78763002/diff/1/components/policy/core/common...
components/policy/core/common/external_data_manager.h:20: class POLICY_EXPORT
ExternalDataManager {
On 2013/11/21 13:55:25, jochen wrote:
> you don't need to export pure virtual interfaces

Done.

[jochen (gone - plz use gerrit), 2013-11-21 14:04:49]

On 2013/11/21 13:57:56, dconnelly wrote:
> On 2013/11/21 13:55:24, jochen wrote:
> > one general question.
> > 
> > You're moving files from browser/ to common/
> > 
> > is this really intended? Are you going to include the headers from a
> > non-browser/ location?
> 
> Yes -- for iOS. I don't think everything I move will be into common/, but most
> of it will.
> 

i see.

But on iOS we don't have multiple processes. Having code that is not intended to
be used across processes in "real" chrome in a folder common/ is confusing imo

[commit-bot: I haz the power, 2013-11-21 14:04:54]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dconnelly, 2013-11-21 14:05:47]

On 2013/11/21 14:04:54, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

whoops, too soon

[jochen (gone - plz use gerrit), 2013-11-21 14:12:24]

lgtm

[commit-bot: I haz the power, 2013-11-21 14:20:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/78763002/70001

[commit-bot: I haz the power, 2013-11-21 14:20:48]

Failed to apply patch for
chrome/browser/policy/configuration_policy_pref_store_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/policy/configuration_policy_pref_store_unittest.cc
  Hunk #1 FAILED at 12.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/policy/configuration_policy_pref_store_unittest.cc.rej

Patch:       chrome/browser/policy/configuration_policy_pref_store_unittest.cc
Index: chrome/browser/policy/configuration_policy_pref_store_unittest.cc
diff --git a/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
b/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
index
b12b10d6ff6d1f18463744183130205ade3ed4da..a3fc8d4e2aec1f1814c1bf0698330dcf4c856a40
100644
--- a/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
+++ b/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
@@ -12,9 +12,9 @@
 #include "base/run_loop.h"
 #include "chrome/browser/policy/configuration_policy_handler.h"
 #include "chrome/browser/policy/configuration_policy_pref_store.h"
-#include "chrome/browser/policy/external_data_fetcher.h"
-#include "chrome/browser/policy/policy_map.h"
 #include "chrome/browser/policy/policy_service_impl.h"
+#include "components/policy/core/common/external_data_fetcher.h"
+#include "components/policy/core/common/policy_map.h"
 #include "components/policy/core/common/policy_pref_names.h"
 #include "testing/gmock/include/gmock/gmock.h"

[commit-bot: I haz the power, 2013-11-21 14:31:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/78763002/180001

[commit-bot: I haz the power, 2013-11-21 17:33:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dconnelly@chromium.org/78763002/270007

[commit-bot: I haz the power, 2013-11-21 19:55:04]

Change committed as 236575

[Joao da Silva, 2013-11-22 17:38:47]

Some cleanups for a later CL

https://codereview.chromium.org/78763002/diff/270007/chrome/browser/policy/co...
File chrome/browser/policy/configuration_policy_provider.cc (right):

https://codereview.chromium.org/78763002/diff/270007/chrome/browser/policy/co...
chrome/browser/policy/configuration_policy_provider.cc:9: #include
"components/policy/core/common/policy_map.h"
This isn't used in this file; maybe it was kept after rebasing on your change
that removed FixObsoletePolicies?

https://codereview.chromium.org/78763002/diff/270007/chrome/browser/policy/po...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/78763002/diff/270007/chrome/browser/policy/po...
chrome/browser/policy/policy_browsertest.cc:52: #include
"chrome/browser/policy/policy_service_impl.h"
This is not used

https://codereview.chromium.org/78763002/diff/270007/components/policy/core/c...
File components/policy/core/common/external_data_fetcher.cc (right):

https://codereview.chromium.org/78763002/diff/270007/components/policy/core/c...
components/policy/core/common/external_data_fetcher.cc:8: #include
"components/policy/core/common/external_data_manager.h"
Included twice?