Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: pkg/compiler/lib/src/cps_ir/redundant_phi.dart

Issue 787603003: Generative constructors in the new dart backend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebased Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.optimizers; 5 part of dart2js.cps_ir.optimizers;
6 6
7 /// Eliminate redundant phis from the given [FunctionDefinition]. 7 /// Eliminate redundant phis from the given [FunctionDefinition].
8 /// 8 ///
9 /// Phis in this case are [Continuations] together with corresponding 9 /// Phis in this case are [Continuations] together with corresponding
10 /// [InvokeContinuation]s. A [Continuation] parameter at position i is redundant 10 /// [InvokeContinuation]s. A [Continuation] parameter at position i is redundant
11 /// if for all [InvokeContinuation]s, the parameter at position i is identical 11 /// if for all [InvokeContinuation]s, the parameter at position i is identical
12 /// (except for feedback). Redundant parameters are removed from the 12 /// (except for feedback). Redundant parameters are removed from the
13 /// continuation signature, all invocations, and replaced within the 13 /// continuation signature, all invocations, and replaced within the
14 /// continuation body. 14 /// continuation body.
15 class RedundantPhiEliminator extends RecursiveVisitor implements Pass { 15 class RedundantPhiEliminator extends RecursiveVisitor with PassMixin {
16 final Set<Continuation> workSet = new Set<Continuation>(); 16 final Set<Continuation> workSet = new Set<Continuation>();
17 17
18 void rewrite(final ExecutableDefinition root) => root.applyPass(this); 18 @override
19
20 void rewriteFunctionDefinition(final FunctionDefinition root) {
21 if (root.isAbstract) return;
22 rewriteExecutableDefinition(root);
23 }
24
25 void rewriteFieldDefinition(final FieldDefinition root) {
26 if (!root.hasInitializer) return;
27 rewriteExecutableDefinition(root);
28 }
29
30 void rewriteExecutableDefinition(final ExecutableDefinition root) { 19 void rewriteExecutableDefinition(final ExecutableDefinition root) {
31 20
32 // Set all parent pointers. 21 // Set all parent pointers.
33 new ParentVisitor().visit(root); 22 new ParentVisitor().visit(root);
34 23
35 // Traverse the tree once to build the work set. 24 // Traverse the tree once to build the work set.
36 visit(root); 25 visit(root);
37 26
38 // Process each continuation one-by-one. 27 // Process each continuation one-by-one.
39 while (workSet.isNotEmpty) { 28 while (workSet.isNotEmpty) {
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 171
183 // Insert it just below the binding of definition. 172 // Insert it just below the binding of definition.
184 InteriorNode binding = definition.parent; 173 InteriorNode binding = definition.parent;
185 174
186 letCont.body = binding.body; 175 letCont.body = binding.body;
187 binding.body.parent = letCont; 176 binding.body.parent = letCont;
188 177
189 binding.body = letCont; 178 binding.body = letCont;
190 letCont.parent = binding; 179 letCont.parent = binding;
191 } 180 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698