Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: pkg/analysis_server/test/domain_completion_test.dart

Issue 787553002: invoke computeCache when priority sources change (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_completion_test.dart
diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart
index e4f7fa3414b0b5a2c312d91f49b0364e7386a6fb..ba315a8bacf422f23af183ad15f1909ac57fb608 100644
--- a/pkg/analysis_server/test/domain_completion_test.dart
+++ b/pkg/analysis_server/test/domain_completion_test.dart
@@ -132,22 +132,6 @@ class CompletionManagerTest extends AbstractAnalysisTest {
}
/**
- * Assert manager is cleared when analysis roots are set
- */
- test_setAnalysisRoots() {
- sendRequest(testFile);
- return pumpEventQueue().then((_) {
- expect(completionDomain.manager, isNotNull);
- request = new AnalysisSetAnalysisRootsParams([], []).toRequest('7');
- Response response = analysisDomain.handleRequest(request);
- expect(response, isResponseSuccess('7'));
- return pumpEventQueue();
- }).then((_) {
- expect(completionDomain.manager, isNull);
- });
- }
-
- /**
* Assert manager is NOT cleared when context NOT associated with manager changes.
*/
test_contextsChanged_different() {
@@ -180,6 +164,22 @@ class CompletionManagerTest extends AbstractAnalysisTest {
}
/**
+ * Assert manager is cleared when analysis roots are set
+ */
+ test_setAnalysisRoots() {
+ sendRequest(testFile);
+ return pumpEventQueue().then((_) {
+ expect(completionDomain.manager, isNotNull);
+ request = new AnalysisSetAnalysisRootsParams([], []).toRequest('7');
+ Response response = analysisDomain.handleRequest(request);
+ expect(response, isResponseSuccess('7'));
+ return pumpEventQueue();
+ }).then((_) {
+ expect(completionDomain.manager, isNull);
+ });
+ }
+
+ /**
* Assert manager is cleared when source NOT associated with manager is changed.
*/
test_sourcesChanged_different_source_changed() {
@@ -443,7 +443,12 @@ class MockCompletionManager implements CompletionManager {
this.cache);
@override
- void compute(CompletionRequest request) {
+ void computeCache() {
+ // ignored
+ }
+
+ @override
+ void computeSuggestions(CompletionRequest request) {
++computeCallCount;
CompletionResult result = new CompletionResult(0, 0, [], true);
controller.add(result);
@@ -453,7 +458,7 @@ class MockCompletionManager implements CompletionManager {
Stream<CompletionResult> results(CompletionRequest request) {
controller = new StreamController<CompletionResult>(onListen: () {
scheduleMicrotask(() {
- compute(request);
+ computeSuggestions(request);
});
});
return controller.stream;
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698