Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2514)

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

Issue 787553002: invoke computeCache when priority sources change (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
index e60f875be8efd23dcf16129828c69da64042065d..1717678156371d6b78948fcc719d44872ec7fbe2 100644
--- a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
@@ -75,13 +75,22 @@ abstract class CompletionManager {
}
/**
+ * Compute and cache information in preparation for a possible code
+ * completion request sometime in the future. The default implementation
+ * of this method does nothing. Subclasses may override but should not
+ * count on this method being called before [computeSuggestions].
+ */
+ void computeCache() {
+ }
+
+ /**
* Compute completion results for the given reqeust and append them to the stream.
* Clients should not call this method directly as it is automatically called
* when a client listens to the stream returned by [results].
* Subclasses should override this method, append at least one result
* to the [controller], and close the controller stream once complete.
*/
- void compute(CompletionRequest request);
+ void computeSuggestions(CompletionRequest request);
/**
* Generate a stream of code completion results.
@@ -89,7 +98,7 @@ abstract class CompletionManager {
Stream<CompletionResult> results(CompletionRequest request) {
controller = new StreamController<CompletionResult>(onListen: () {
scheduleMicrotask(() {
- compute(request);
+ computeSuggestions(request);
});
});
return controller.stream;
@@ -198,7 +207,7 @@ class NoOpCompletionManager extends CompletionManager {
NoOpCompletionManager(Source source) : super(null, source);
@override
- void compute(CompletionRequest request) {
+ void computeSuggestions(CompletionRequest request) {
controller.add(new CompletionResult(request.offset, 0, [], true));
}
}

Powered by Google App Engine
This is Rietveld 408576698