Issue 787403003: ui/aura: No need to not check for 'use_aura' in a aura specific build file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 787403003: ui/aura: No need to not check for 'use_aura' in a aura specific build file. (Closed)

Created:
6 years ago by tfarina

Modified:
6 years ago

Reviewers:
Slava Chigrin, sky

CC:
chromium-reviews, kalyank, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

ui/aura: No need to not check for 'use_aura' in a aura specific build file. As noted in https://codereview.chromium.org/806183002/diff/20001/ui/aura/BUILD.gn#newcode195 BUG=None R=sky@chromium.org Committed: https://crrev.com/ca865e820d7c998ba1c9ea043e6ee388d221387e Cr-Commit-Position: refs/heads/master@{#309118}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -14 lines)			Patch
	M	ui/aura/BUILD.gn	View		1 chunk	+8 lines, -14 lines	0 comments	Download

Total messages: 7 (1 generated)

Slava Chigrin

On 2014/12/17 22:50:43, tfarina wrote: > PTAL LGTM (althogh I am not owner). Thank you ...

6 years ago (2014-12-18 09:08:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787403003/1

6 years ago (2014-12-19 00:35:57 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-19 00:52:01 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ca865e820d7c998ba1c9ea043e6ee388d221387e
Cr-Commit-Position: refs/heads/master@{#309118}