Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 787393003: Add access to read-only properties (Closed)

Created:
6 years ago by perezju
Modified:
6 years ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add access to read-only properties This CL adds efficient access to read-only properties of a device. The properties thus accessible are: - build_description - build_fingerprint - build_id - build_product - build_type - build_version_sdk (returns a number) - product_cpu_abi - product_model - product_name These properties are required to eliminate the need of some accesses to android_commands through device.old_interface. Other properties can still be accessed (and cached if requested), using DeviceUtils.GetProp. BUG=267773 Committed: https://crrev.com/d8240c07691d81093653da6d406039aa6d741439 Cr-Commit-Position: refs/heads/master@{#308164}

Patch Set 1 #

Patch Set 2 : migrate clients to use properties #

Total comments: 4

Patch Set 3 : example strings from a user device #

Total comments: 1

Patch Set 4 : add missing timeout/retry defaults #

Patch Set 5 : use instance defaults for timeout/retry #

Patch Set 6 : rebase against master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -35 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M build/android/pylib/content_settings.py View 1 1 chunk +3 lines, -7 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 3 4 5 5 chunks +81 lines, -8 lines 0 comments Download
M build/android/pylib/device_settings.py View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M build/android/pylib/instrumentation/test_jar.py View 1 1 chunk +3 lines, -5 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/perf/perf_control.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/tombstones.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
perezju
We mentioned about adding this read-only properties a while back. I'm adding the properties here ...
6 years ago (2014-12-10 13:37:34 UTC) #2
jbudorick
https://codereview.chromium.org/787393003/diff/20001/build/android/pylib/instrumentation/test_runner.py File build/android/pylib/instrumentation/test_runner.py (left): https://codereview.chromium.org/787393003/diff/20001/build/android/pylib/instrumentation/test_runner.py#oldcode447 build/android/pylib/instrumentation/test_runner.py:447: < constants.ANDROID_SDK_VERSION_CODES.JELLY_BEAN): On 2014/12/10 13:37:34, perezju wrote: > Note ...
6 years ago (2014-12-11 02:05:57 UTC) #3
perezju
https://codereview.chromium.org/787393003/diff/40001/build/android/pylib/device_settings.py File build/android/pylib/device_settings.py (right): https://codereview.chromium.org/787393003/diff/40001/build/android/pylib/device_settings.py#newcode9 build/android/pylib/device_settings.py:9: from pylib.device import device_errors embarrassing mistake, ouch :-/
6 years ago (2014-12-12 10:13:16 UTC) #4
jbudorick
lgtm
6 years ago (2014-12-12 14:15:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787393003/80001
6 years ago (2014-12-12 16:36:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30064)
6 years ago (2014-12-12 16:41:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787393003/100001
6 years ago (2014-12-12 19:45:13 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years ago (2014-12-12 21:34:16 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-12 21:34:57 UTC) #13
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/d8240c07691d81093653da6d406039aa6d741439
Cr-Commit-Position: refs/heads/master@{#308164}

Powered by Google App Engine
This is Rietveld 408576698