Pass seek event through pipeline during loading state

media/blink/webmediaplayer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/blink/webmediaplayer_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <string>
 #include <vector>
@@ skipping 292 matching lines @@
   DCHECK(main_task_runner_->BelongsToCurrentThread());
   return supports_save_;
 }
 
 void WebMediaPlayerImpl::seek(double seconds) {
   DVLOG(1) << __FUNCTION__ << "(" << seconds << "s)";
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
   ended_ = false;
 
+  ReadyState old_state = ready_state_;
   if (ready_state_ > WebMediaPlayer::ReadyStateHaveMetadata)
     SetReadyState(WebMediaPlayer::ReadyStateHaveMetadata);
 
   base::TimeDelta seek_time = ConvertSecondsToTimestamp(seconds);
 
   if (seeking_) {
     pending_seek_ = true;
     pending_seek_seconds_ = seconds;
     if (chunk_demuxer_)
       chunk_demuxer_->CancelPendingSeek(seek_time);
     return;
   }
 
   media_log_->AddEvent(media_log_->CreateSeekEvent(seconds));
 
   // Update our paused time.
   // In paused state ignore the seek operations to current time and generate
   // OnPipelineSeeked and OnPipelineBufferingStateChanged events
   // to eventually fire seeking and seeked events
   if (paused_) {
-    if (paused_time_ != seek_time) {
+    if (paused_time_ != seek_time || old_state != ReadyStateHaveEnoughData) {

[DaleCurtis, 2015/01/06 19:18:55]

Can you see if this allows the removal of OnPipelineSeeked() now? I.e. move the
inverse of this state check to the PostTask for
OnPipelineBufferingStateChanged(). 

if (paused_time_ != seek_time) {
  paused_time_ = seek_time;
} else if (old_state == ReadyStateHaveEnoughData) {
  // PostTask(OnPipelineBufferingStateChanged);
  return;
}

This will avoid redoing the seek to the beginning if load is still in progress. 
I also don't remember exactly why the OnPipelineSeeked() is necessary. The load
event should eventually completely and issue the correct buffering state change.

       paused_time_ = seek_time;
     } else {
       main_task_runner_->PostTask(
           FROM_HERE, base::Bind(&WebMediaPlayerImpl::OnPipelineSeeked,
                                 AsWeakPtr(), false, PIPELINE_OK));
       main_task_runner_->PostTask(
           FROM_HERE,
           base::Bind(&WebMediaPlayerImpl::OnPipelineBufferingStateChanged,
                      AsWeakPtr(), BUFFERING_HAVE_ENOUGH));
       return;
@@ skipping 682 matching lines @@
   compositor_task_runner_->PostTask(FROM_HERE,
                                     base::Bind(&GetCurrentFrameAndSignal,
                                                base::Unretained(compositor_),
                                                &video_frame,
                                                &event));
   event.Wait();
   return video_frame;
 }
 
 }  // namespace media