Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: Source/core/animation/CompositorAnimations.cpp

Issue 787353003: Animation: Allow cubic-bezier timing inputs outside the range [0, 1] in CC (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@0
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/CompositorAnimations.cpp
diff --git a/Source/core/animation/CompositorAnimations.cpp b/Source/core/animation/CompositorAnimations.cpp
index 0fe99df503e323520548dfdd3d60529615359daf..e405b9f5c8477ada5f3ee248d14ced3de81a28ec 100644
--- a/Source/core/animation/CompositorAnimations.cpp
+++ b/Source/core/animation/CompositorAnimations.cpp
@@ -173,20 +173,6 @@ bool CompositorAnimations::isCandidateForAnimationOnCompositor(const Timing& tim
if (!CompositorAnimationsImpl::convertTimingForCompositor(timing, 0, out, playerPlaybackRate))
return false;
- if (timing.timingFunction->type() == TimingFunction::CubicBezierFunction) {
- // FIXME: Fix compositor timing functions to accept inputs outside of
- // [0,1].
- const CubicBezierTimingFunction& cubic = toCubicBezierTimingFunction(*timing.timingFunction);
- const KeyframeVector& keyframes = keyframeEffect.getFrames();
- double startRange = 0;
- double endRange = 1;
- cubic.range(&startRange, &endRange);
-
- ASSERT(keyframes.size() >= 2);
- if ((startRange < 0 || endRange > 1) && (keyframes.first()->easing().type() != TimingFunction::LinearFunction || keyframes[keyframes.size() - 2]->easing().type() != TimingFunction::LinearFunction))
- return false;
- }
-
return true;
}
« no previous file with comments | « ManualTests/animation/compositor-animation-steps.html ('k') | Source/core/animation/CompositorAnimationsTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698