libwebp: cherry-pick non-Xcode clang (iOS) build fix

libwebp: cherry-pick non-Xcode clang (iOS) build fix

check for __apple_build_version__ to distinguish the two; a version
check could work as Apple bumped Xcode's to 5.x/6.x, but it's unclear
how upstream will deal with their versioning as they go 3.6+, so avoid
it for now.

Change-Id: I67cda67c4f68e262a92d805a63cc1496374be063

BUG=436897
Committed: https://crrev.com/14bada710752470e889688b34f5b715a5c62680a
Cr-Commit-Position: refs/heads/master@{#307949}

[jzern, 2014-12-11 02:09:33]

jzern@chromium.org changed reviewers:
+ sdefresne@chromium.org

[skal, 2014-12-11 08:47:23]

skal@google.com changed reviewers:
+ skal@google.com

[skal, 2014-12-11 08:47:23]

lgtm

but i'll let sdefresne@ have the final say

[sdefresne, 2014-12-11 10:23:10]

lgtm

I've tested the patch and it compiles fine with both upstream clang as shipped
with Chromium and with Xcode version of clang.

[skal, 2014-12-11 10:30:22]

The CQ bit was checked by skal@google.com

[skal, 2014-12-11 10:30:22]

lgtm

submitted upstream

[commit-bot: I haz the power, 2014-12-11 10:30:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787333007/1

[commit-bot: I haz the power, 2014-12-11 10:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-11 10:33:58]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sdefresne, 2014-12-11 10:45:14]

sdefresne@chromium.org changed reviewers:
+ fbarchard@chromium.org, urvang@google.com

[sdefresne, 2014-12-11 10:45:32]

On 2014/12/11 at 10:45:14, sdefresne wrote:
> sdefresne@chromium.org changed reviewers:
> + fbarchard@chromium.org, urvang@google.com

urvang, fbarchard: needs an OWNERS lgtm.

[urvang (Google), 2014-12-11 17:56:33]

lgtm

[fbarchard, 2014-12-11 18:00:58]

lgtm

https://codereview.chromium.org/787333007/diff/1/third_party/libwebp/dsp/enc_...
File third_party/libwebp/dsp/enc_neon.c (right):

https://codereview.chromium.org/787333007/diff/1/third_party/libwebp/dsp/enc_...
third_party/libwebp/dsp/enc_neon.c:1017: defined(__apple_build_version__)
curious what this tests?  maybe worth a comment

[skal, 2014-12-11 18:03:32]

On 2014/12/11 18:00:58, fbarchard wrote:
> lgtm
> 
>
https://codereview.chromium.org/787333007/diff/1/third_party/libwebp/dsp/enc_...
> File third_party/libwebp/dsp/enc_neon.c (right):
> 
>
https://codereview.chromium.org/787333007/diff/1/third_party/libwebp/dsp/enc_...
> third_party/libwebp/dsp/enc_neon.c:1017: defined(__apple_build_version__)
> curious what this tests?  maybe worth a comment

(comment is in the CL description)

[skal, 2014-12-11 18:03:34]

On 2014/12/11 18:00:58, fbarchard wrote:
> lgtm
> 
>
https://codereview.chromium.org/787333007/diff/1/third_party/libwebp/dsp/enc_...
> File third_party/libwebp/dsp/enc_neon.c (right):
> 
>
https://codereview.chromium.org/787333007/diff/1/third_party/libwebp/dsp/enc_...
> third_party/libwebp/dsp/enc_neon.c:1017: defined(__apple_build_version__)
> curious what this tests?  maybe worth a comment

(comment is in the CL description)

[jzern, 2014-12-11 19:19:36]

The CQ bit was checked by jzern@chromium.org

[commit-bot: I haz the power, 2014-12-11 19:20:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787333007/1

[commit-bot: I haz the power, 2014-12-11 19:32:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-11 19:34:31]

Patchset 1 (id:??) landed as
https://crrev.com/14bada710752470e889688b34f5b715a5c62680a
Cr-Commit-Position: refs/heads/master@{#307949}