src/IceConverter.cpp - Issue 787333005: Subzero: Pull the node name out of the node structure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceConverter.cpp

Issue 787333005: Subzero: Pull the node name out of the node structure. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Add a comment Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceConverter.cpp

diff --git a/src/IceConverter.cpp b/src/IceConverter.cpp

index e06e290238d76932e06bda54b387352fbe0052e1..a8148f97ad1f7bd3333b07435ac4e5cd2e64c463 100644

--- a/src/IceConverter.cpp

+++ b/src/IceConverter.cpp

@@ -156,7 +156,9 @@ private:

Ice::CfgNode *mapBasicBlockToNode(const BasicBlock *BB) {

if (NodeMap.find(BB) == NodeMap.end()) {

- NodeMap[BB] = Func->makeNode(BB->getName());

+ NodeMap[BB] = Func->makeNode();

+ if (ALLOW_DUMP)

+ NodeMap[BB]->setName(BB->getName());

}

return NodeMap[BB];

}

« no previous file with comments | « src/IceCfgNode.cpp ('k') | src/PNaClTranslator.cpp » ('j') | no next file with comments »