Issue 787333005: Subzero: Pull the node name out of the node structure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 787333005: Subzero: Pull the node name out of the node structure. (Closed)

Created:
6 years ago by Jim Stichnoth

Modified:
6 years ago

Reviewers:
jvoung (off chromium), Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Pull the node name out of the node structure. Instead, non-empty node names are kept in a single vector in the Cfg object. This is toward the goal of pulling non-POD fields out of the CfgNode class so that CfgNode can be arena-allocated and not leak memory. Also, actual setting of the node name is now guarded by ALLOW_DUMP. BUG= none R=jvoung@chromium.org, kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=668a7a333d6ddc3102b5b7c7c07448f6d259113c

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -18 lines)			Patch
M	src/IceCfg.h	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	src/IceCfg.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/IceCfgNode.h	View		2 chunks	+8 lines, -7 lines	0 comments	Download
M	src/IceCfgNode.cpp	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	src/IceConverter.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/PNaClTranslator.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Jim Stichnoth

6 years ago (2014-12-10 23:32:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
668a7a333d6ddc3102b5b7c7c07448f6d259113c (presubmit successful).