Clean up render_frame_impl.cc removing unnecessary static.

Clean up render_frame_impl.cc removing unnecessary static.

Committed: https://crrev.com/b721ddf2c0d00a889a25fc32c954489e05294234
Cr-Commit-Position: refs/heads/master@{#307763}

[dshwang, 2014-12-10 09:02:32]

dongseong.hwang@intel.com changed reviewers:
+ creis@chromium.org

[dshwang, 2014-12-10 09:02:32]

could you review this small clean up?
I extract this from https://codereview.chromium.org/445013002/ as you mentioned.

[mlamouri (slow - plz ping), 2014-12-10 09:50:03]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2014-12-10 09:50:03]

drive-by lgtm

https://codereview.chromium.org/787333003/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/787333003/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:476: using CreateRenderFrameImpl =
RenderFrameImpl* (*)(RenderViewImpl*, int32);
nit: I would pick a clearer name like CreateRenderFrameImplFunction. I'm not
sure if the coding style has a rule wrt this though.

[dshwang, 2014-12-10 10:08:31]

Thank you for reviewing!

https://codereview.chromium.org/787333003/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/787333003/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:476: using CreateRenderFrameImpl =
RenderFrameImpl* (*)(RenderViewImpl*, int32);
On 2014/12/10 09:50:03, Mounir Lamouri wrote:
> nit: I would pick a clearer name like CreateRenderFrameImplFunction. I'm not
> sure if the coding style has a rule wrt this though.

I rename it to CreateRenderFrameImplFunction.
James suggests using type alias in
https://codereview.chromium.org/445013002/#msg38

[Charlie Reis, 2014-12-10 18:13:19]

Thanks!  One note below, from my previous comment.

https://codereview.chromium.org/787333003/diff/20001/content/renderer/render_...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/787333003/diff/20001/content/renderer/render_...
content/renderer/render_frame_impl.cc:554: RenderFrameImpl*
(*create_render_frame_impl)(RenderViewImpl*, int32)) {
Can you also update this?

[dshwang, 2014-12-10 18:48:57]

Thank you for reviewing. Done.

https://codereview.chromium.org/787333003/diff/20001/content/renderer/render_...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/787333003/diff/20001/content/renderer/render_...
content/renderer/render_frame_impl.cc:554: RenderFrameImpl*
(*create_render_frame_impl)(RenderViewImpl*, int32)) {
On 2014/12/10 18:13:19, Charlie Reis wrote:
> Can you also update this?

Done.

[Charlie Reis, 2014-12-10 19:27:34]

Thanks!  LGTM.

(Don't worry about the checkdeps try job failures; that's from an unrelated CL.)

[dshwang, 2014-12-10 20:31:02]

On 2014/12/10 19:27:34, Charlie Reis wrote:
> Thanks!  LGTM.
> 
> (Don't worry about the checkdeps try job failures; that's from an unrelated
CL.)

Thank you for reviewing!

[dshwang, 2014-12-10 20:31:06]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2014-12-10 20:32:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787333003/40001

[commit-bot: I haz the power, 2014-12-10 21:22:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-10 21:23:51]

Patchset 3 (id:??) landed as
https://crrev.com/b721ddf2c0d00a889a25fc32c954489e05294234
Cr-Commit-Position: refs/heads/master@{#307763}