Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: runtime/vm/il_printer.cc

Issue 78733002: Generalize if-conversion to arbitrary smi comparisons. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/il_printer.cc
===================================================================
--- runtime/vm/il_printer.cc (revision 30464)
+++ runtime/vm/il_printer.cc (working copy)
@@ -365,6 +365,9 @@
left()->PrintTo(f);
f->Print(", ");
right()->PrintTo(f);
+ if (needs_number_check()) {
+ f->Print(", with number check");
+ }
}
@@ -427,9 +430,7 @@
void IfThenElseInstr::PrintOperandsTo(BufferFormatter* f) const {
- left()->PrintTo(f);
- f->Print(" %s ", Token::Str(kind_));
- right()->PrintTo(f);
+ comparison()->PrintOperandsTo(f);
f->Print(" ? %" Pd " : %" Pd,
if_true_,
if_false_);
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698