runtime/vm/compiler.cc - Issue 78733002: Generalize if-conversion to arbitrary smi comparisons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 78733002: Generalize if-conversion to arbitrary smi comparisons. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: added missing test file Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/compiler.cc

===================================================================

--- runtime/vm/compiler.cc (revision 30464)

+++ runtime/vm/compiler.cc (working copy)

@@ -370,7 +370,11 @@

DEBUG_ASSERT(flow_graph->VerifyUseLists());

// Do optimizations that depend on the propagated type information.

- optimizer.Canonicalize();

+ if (optimizer.Canonicalize()) {

+ // Invoke Canonicalize twice in order to fully canonicalize certains

Kevin Millikin (Google) 2013/11/22 14:09:34 certains ==> certain, or just get rid of it becaus

+ // patterns like "if (a & const == 0) { }".

+ optimizer.Canonicalize();

+ }

DEBUG_ASSERT(flow_graph->VerifyUseLists());

BranchSimplifier::Simplify(flow_graph);

« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | runtime/vm/flow_graph_builder.cc » ('J')