Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 7873004: Merge 94964 - [chromium] REGRESSION(94353): Compositor textures and resources leaked when tab clo... (Closed)

Created:
8 years, 11 months ago by jamesr
Modified:
8 years, 11 months ago
Reviewers:
jamesr1
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94964 - [chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process https://bugs.webkit.org/show_bug.cgi?id=67816 Reviewed by Kenneth Russell. We lack infrastructure to construct an automated test for this today. To test manually, open up a composited page (like the poster circle), duplicate the tab many times, close all the duplicates, and verify that the memory use returns to the single tab level. * platform/graphics/chromium/LayerChromium.h: * platform/graphics/chromium/TiledLayerChromium.cpp: (WebCore::TiledLayerChromium::setLayerTreeHost): * platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::setLayerTreeHost): * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: (WebCore::CCLayerTreeHost::clearRenderSurfacesRecursive): (WebCore::CCLayerTreeHost::setRootLayer): * platform/graphics/chromium/cc/CCLayerTreeHost.h: TBR=jamesr@google.com BUG=96288 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94967

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4425 lines, -3 lines) Patch
M Source/WebCore/ChangeLog View 2 chunks +4400 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/LayerChromium.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/TiledLayerChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
8 years, 11 months ago (2011-09-12 17:58:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698