Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 787253009: Fix crash when opening native messaging channel. (Closed)

Created:
5 years, 11 months ago by Sergey Ulanov
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@audio_period
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash when opening native messaging channel. RenderWidgetHost::GetView() may return NULL, e.g. if the renderer has crashed. MessageService::OpenChannelToNativeApp() wasn't handling this case properly. BUG=374778 Committed: https://crrev.com/41d870461176a8f76402a64ea4c1a4bf00275178 Cr-Commit-Position: refs/heads/master@{#310160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/extensions/api/messaging/message_service.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
5 years, 11 months ago (2015-01-06 18:09:39 UTC) #2
not at google - send to devlin
lgtm
5 years, 11 months ago (2015-01-06 20:37:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787253009/1
5 years, 11 months ago (2015-01-06 21:23:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 22:30:37 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 22:31:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/41d870461176a8f76402a64ea4c1a4bf00275178
Cr-Commit-Position: refs/heads/master@{#310160}

Powered by Google App Engine
This is Rietveld 408576698