Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 787253005: QUIC - use the correct type and fix the formatting fixes. (Closed)

Created:
6 years ago by ramant (doing other things)
Modified:
6 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - use the correct type and fix the formatting fixes. Changes found while merging the following change from Peter Kasting into the internal source tree. "pkasting CL: https://codereview.chromium.org/761863002/ Clean up type usage and fix MSVC "truncated value" warnings in net/quic/. The existing code is very inconsistent about whether it uses typedefs like QuickByteCount and QuicPacketCount or whether it instead uses fundamental types like uint32, uint64, and size_t. This is not only more confusing to read, in some cases it leads to MSVC warning about "possibly truncated value" when one type is implicitly converted to another, shorter one. This attempts to fix at least some of these sorts of problems by using the typedefed types more widely when possible, or else at least the same basic types other places are already using. It also fixes various warnings by including explicit casts (sometimes with legality checks)." No functionality change. Changes to keep the code similar to internal source tree. Merge internal change: 81428557 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M net/quic/quic_connection_stats.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_data_writer.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M net/quic/quic_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years ago (2014-12-13 01:54:56 UTC) #1
Ryan Hamilton
6 years ago (2014-12-15 16:43:30 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698