Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 787223005: Fix navigations in OOP PDF (Closed)

Created:
5 years, 11 months ago by raymes
Modified:
5 years, 11 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix navigations in OOP PDF Navigations broke as a result of being inside a browser plugin because the embedded WebContents would be navigated instead of the top-level one. This change switches to use the chrome.tabs API to do navigations which fixes this problem. BUG=446390 Committed: https://crrev.com/8ba5a02786e485034353eebddb1bd9aee2b69b46 Cr-Commit-Position: refs/heads/master@{#310062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
5 years, 11 months ago (2015-01-06 06:04:52 UTC) #2
Sam McNally
lgtm
5 years, 11 months ago (2015-01-06 06:15:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787223005/1
5 years, 11 months ago (2015-01-06 06:16:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 07:08:13 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 07:08:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ba5a02786e485034353eebddb1bd9aee2b69b46
Cr-Commit-Position: refs/heads/master@{#310062}

Powered by Google App Engine
This is Rietveld 408576698