Issue 787183003: Revert of revert r25736

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 787183003: Revert of revert r25736 (Closed)

Created:
6 years ago by dcarney

Modified:
6 years ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert of revert r25736 (patchset #2 id:20001 of https://codereview.chromium.org/803493002/) Reason for revert: performance bots were unchanged by the original revert Original issue's description: > revert r25736 > > R=bmeurer@chromium.org > > BUG= TBR=bmeurer@chromium.org NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+139 lines, -104 lines)			Patch
M	src/compiler/graph-visualizer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/instruction.h	View	5 chunks	+3 lines, -10 lines	0 comments	Download
M	src/compiler/instruction.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/compiler/pipeline.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/compiler/register-allocator.h	View	5 chunks	+35 lines, -12 lines	0 comments	Download
M	src/compiler/register-allocator.cc	View	17 chunks	+90 lines, -77 lines	0 comments	Download
M	src/compiler/register-allocator-verifier.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787183003/1

6 years ago (2014-12-12 14:26:01 UTC) #2

Weiliang

6 years ago (2014-12-12 16:07:49 UTC) #4

Message was sent while issue was closed.

On 2014/12/12 14:25:44, dcarney wrote:
> Created Revert of revert r25736
Hi

The regression of r25736 is restored by
r25772(https://codereview.chromium.org/795043003).

Expand Messages | Collapse Messages