Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 78713009: Introduce toV8NoInline (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Do not generate toV8Inline if CustomToV8 is specified. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 2bdd440753d9592507703936591aa7576267375e..5dbe36753fa5df648e3caf1f1b9769c3b0b38fb5 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -4752,6 +4752,16 @@ void ${v8ClassName}::derefObject(void* object)
}
END
+ if (!$interface->extendedAttributes->{"DoNotGenerateToV8"} && !$interface->extendedAttributes->{"CustomToV8"}) {
haraken 2013/11/23 15:03:18 Probably we can auto-generate toV8NoInline when [C
yhirano 2013/11/25 01:50:52 ConsoleBase has toV8Custom attribute but the custo
haraken 2013/11/25 02:39:23 Yes! It won't make sense to have [toV8Custom] but
yhirano 2013/11/25 03:36:49 Done. We can't omit toV8NoInline in V8ArrayBufferC
+ $implementation{nameSpaceWebCore}->add(<<END);
+template<>
+v8::Handle<v8::Value> toV8NoInline(${nativeType}* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
+ return toV8(impl, creationContext, isolate);
+}
+
+END
+ }
}
sub GenerateHeaderContentHeader
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8SupportTestInterface.cpp » ('j') | Source/bindings/v8/V8Binding.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698