src/lexer/lexer.gyp - Issue 78713002: Experimental lexer generator: generate code for utf-16 character classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lexer/lexer.gyp

Issue 78713002: Experimental lexer generator: generate code for utf-16 character classes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser

Patch Set: Code review (dcarney) Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lexer/lexer.gyp

diff --git a/src/lexer/lexer.gyp b/src/lexer/lexer.gyp

index 03a74dfb2edd412e7dc23c69105728f6146476a8..4b961e78ad4ef52640061756fdfb8958dcef58f8 100644

--- a/src/lexer/lexer.gyp

+++ b/src/lexer/lexer.gyp

@@ -74,7 +74,7 @@

'../../tools/lexer_generator/generator.py',

'--re=../../src/lexer/lexer_py.re',

'--code=<(SHARED_INTERMEDIATE_DIR)/generated_lexer_latin1.cc',

- '--char-type=uint8_t',

+ '--encoding=latin1',

{

@@ -92,7 +92,7 @@

'../../tools/lexer_generator/generator.py',

'--re=../../src/lexer/lexer_py.re',

'--code=<(SHARED_INTERMEDIATE_DIR)/generated_lexer_utf16.cc',

- '--char-type=uint16_t',

+ '--encoding=utf16',

« no previous file with comments | « src/char-predicates.h ('k') | src/lexer/lexer_py.re » ('j') | no next file with comments »