Issue 78713002: Experimental lexer generator: generate code for utf-16 character classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78713002: Experimental lexer generator: generate code for utf-16 character classes. (Closed)

Created:
7 years, 1 month ago by marja

Modified:
7 years, 1 month ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental lexer generator: generate code for utf-16 character classes. R=dcarney@chromium.org TBR=dcarney@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17936

Patch Set 2 : Code review (dcarney) #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -28 lines)			Patch
M	src/char-predicates.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/lexer/lexer.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/lexer/lexer_py.re	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/scanner.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/lexer_generator/code_generator.jinja	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	tools/lexer_generator/code_generator.py	View	1	3 chunks	+10 lines, -3 lines	0 comments	Download
M	tools/lexer_generator/generator.py	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
M	tools/lexer_generator/transition_key_test.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/lexer_generator/transition_keys.py	View	1	2 chunks	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dcarney

lgtm https://codereview.chromium.org/78713002/diff/1/tools/lexer_generator/transition_keys.py File tools/lexer_generator/transition_keys.py (right): https://codereview.chromium.org/78713002/diff/1/tools/lexer_generator/transition_keys.py#newcode144 tools/lexer_generator/transition_keys.py:144: 'eos', 'zero']: class_name in __class_bounds.keys()?

7 years, 1 month ago (2013-11-20 16:05:16 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 manually as r17936.

Expand Messages | Collapse Messages

Issue 78713002: Experimental lexer generator: generate code for utf-16 character classes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review (dcarney) #

Messages