This fixes http://code.google.com/p/chromium/issues/detail?id=3585, which is ...

This fixes http://code.google.com/p/chromium/issues/detail?id=3585, which is an issue with videos on sites like thedailyshow.com not showing up in Chrome. We recently made a change to send out the plugin SRC as the referrer in requests initiated by plugins.We also use the GetURLNotify codepath for requests which are initiated by us when the plugin is instantiated. It looks like the other browsers don't do the same, and only use the SRC as the referer for explicit plugin requests.Based on a reply on the PluginFutures list we emulate this behavior, which is to default to the containing frame URL as the referer for requests not initiated by plugins.

R=jam


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3862

[jam, 2008-10-22 20:00:28]

http://codereview.chromium.org/7871/diff/1/8
File chrome/common/plugin_messages.h (right):

http://codereview.chromium.org/7871/diff/1/8#newcode51
Line 51: bool use_plugin_src_as_referer;
referer-> referrer (and everywhere else)

http://codereview.chromium.org/7871/diff/1/4
File webkit/glue/plugins/plugin_host.cc (right):

http://codereview.chromium.org/7871/diff/1/4#newcode371
Line 371: true);
how come NPN_GetURLNotify sets use_plugin_src_as_referer=true while NPN_GetURL
uses false?  Shouldn't they be the same?

http://codereview.chromium.org/7871/diff/1/7
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/7871/diff/1/7#newcode1212
Line 1212: GURL(complete_url_string), range_info, false);
isn't this plugin-initiated?  shouldn't it be true?

[ananta, 2008-10-22 22:12:01]

Hi John

Please take another look.

Thanks
Ananta

[jam, 2008-10-22 22:33:19]

It seems that the only time this new flag is false is from
WebPluginDelegateImpl::UpdateGeometry, which also keeps around
first_geometry_update_ for this purpose.  wouldn't it be simpler to move
first_geometry_update_ to WebPluginImpl?  You wouldn't need to change most of
these files then right?

[jam, 2008-10-22 23:45:44]

http://codereview.chromium.org/7871/diff/83/244
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/7871/diff/83/244#newcode1164
Line 1164: bool use_plugin_src_as_referrer = (first_geometry_update_ == false);
I don't think this will always work (and is a bit hard to read).  If
load_manually_ is true, and before the plugin paints it calls NPN_GetURL, then
the wrong referrer will be used.

Why not just have HandleURLRequestcall HandleURLRequestInternal that takes this
extra flag?  then the code around like 650 can just call the internal version
with the flag.

[jam, 2008-10-23 00:22:16]

lgtm

http://codereview.chromium.org/7871/diff/256/257
File webkit/glue/webplugin_impl.cc (right):

http://codereview.chromium.org/7871/diff/256/257#newcode1179
Line 1179: 
extra space here