LayoutTests/css3/calc/calc-with-percent-and-number-in-line-height-crash.html - Issue 787073006: Fix number handling in accumulatePixelsAndPercent.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/calc/calc-with-percent-and-number-in-line-height-crash.html

Issue 787073006: Fix number handling in accumulatePixelsAndPercent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix the previous fail. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/css3/calc/calc-with-percent-and-number-in-line-height-crash-expected.txt » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <style>	2 <style>

3 inputtext::content:focus { }	3 * {

	4 line-height: calc(100% + 30);

	5 }

4 </style>	6 </style>

5 // This test passes if it doesn't crash.	7 <p>PASS if it does not crash in debug.</p>

6 <script>	8 <script>

7 if (window.testRunner)	9 if (window.testRunner)

8 testRunner.dumpAsText();	10 testRunner.dumpAsText();

9 </script>	11 </script>

OLD	NEW