Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 787073006: Fix number handling in accumulatePixelsAndPercent. (Closed)

Created:
6 years ago by reni
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis, Mike West
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix number handling in accumulatePixelsAndPercent. blink::CSSCalcPrimitiveValue::accumulatePixelsAndPercent supposes that it only can receive values with length or percentage unit types and misses the case when a number is received. The patch makes this function aware of such situations. BUG=442293 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188029

Patch Set 1 #

Patch Set 2 : Updated patch #

Patch Set 3 : Update #

Patch Set 4 : Fix the previous fail. #

Total comments: 1

Patch Set 5 : Release parsedCalculation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
A + LayoutTests/css3/calc/calc-with-percent-and-number-in-line-height-crash.html View 1 chunk +4 lines, -2 lines 0 comments Download
A + LayoutTests/css3/calc/calc-with-percent-and-number-in-line-height-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
reni
6 years ago (2014-12-15 15:50:20 UTC) #1
Timothy Loh
+alancutter I'm not sure if we should actually be allowed to calc(percent + number) here ...
6 years ago (2014-12-15 22:28:14 UTC) #3
reni
On 2014/12/15 22:28:14, Timothy Loh wrote: > +alancutter > > I'm not sure if we ...
6 years ago (2014-12-16 19:08:18 UTC) #4
Timothy Loh
On 2014/12/16 19:08:18, reni wrote: > On 2014/12/15 22:28:14, Timothy Loh wrote: > > +alancutter ...
6 years ago (2014-12-17 03:22:32 UTC) #5
reni
6 years ago (2014-12-20 01:26:54 UTC) #6
alancutter (OOO until 2018)
Non-OWNER lgtm with nits. Description needs updating to match patch. https://codereview.chromium.org/787073006/diff/60001/Source/core/css/parser/CSSPropertyParser.cpp File Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/787073006/diff/60001/Source/core/css/parser/CSSPropertyParser.cpp#newcode4690 ...
5 years, 11 months ago (2014-12-31 03:38:08 UTC) #8
Timothy Loh
On 2014/12/31 03:38:08, alancutter wrote: > Non-OWNER lgtm with nits. > Description needs updating to ...
5 years, 11 months ago (2015-01-07 06:29:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787073006/80001
5 years, 11 months ago (2015-01-07 16:35:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/23630)
5 years, 11 months ago (2015-01-07 16:41:48 UTC) #13
reni
Thanks for the reviews! But it seems that we still lack of an OWNER lgtm ...
5 years, 11 months ago (2015-01-07 19:25:14 UTC) #14
Timothy Loh
On 2015/01/07 19:25:14, reni wrote: > Thanks for the reviews! But it seems that we ...
5 years, 11 months ago (2015-01-07 22:50:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787073006/80001
5 years, 11 months ago (2015-01-08 07:44:10 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 07:48:55 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188029

Powered by Google App Engine
This is Rietveld 408576698