Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 787073003: Adding an option for pixelated rendering in SkPictureImageFilter (Closed)

Created:
6 years ago by Justin Novosad
Modified:
6 years ago
Reviewers:
Stephen White, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Adding an option for pixelated rendering in SkPictureImageFilter BUG=skia:3209 Committed: https://skia.googlesource.com/skia/+/f3c78ccf5694d22d2e4a7061a80399a7e69b59db

Patch Set 1 #

Total comments: 1

Patch Set 2 : filter level #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -20 lines) Patch
M gm/pictureimagefilter.cpp View 1 3 chunks +10 lines, -2 lines 0 comments Download
M include/core/SkPicture.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 1 4 chunks +6 lines, -3 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 5 chunks +27 lines, -13 lines 1 comment Download

Messages

Total messages: 10 (2 generated)
Justin Novosad
PTAL
6 years ago (2014-12-09 15:42:32 UTC) #2
Stephen White
https://codereview.chromium.org/787073003/diff/1/include/effects/SkPictureImageFilter.h File include/effects/SkPictureImageFilter.h (right): https://codereview.chromium.org/787073003/diff/1/include/effects/SkPictureImageFilter.h#newcode44 include/effects/SkPictureImageFilter.h:44: bool pixelated = false) { I think this should ...
6 years ago (2014-12-09 16:22:10 UTC) #3
Justin Novosad
Done.
6 years ago (2014-12-09 16:51:04 UTC) #4
Stephen White
LGTM https://codereview.chromium.org/787073003/diff/20001/src/effects/SkPictureImageFilter.cpp File src/effects/SkPictureImageFilter.cpp (right): https://codereview.chromium.org/787073003/diff/20001/src/effects/SkPictureImageFilter.cpp#newcode58 src/effects/SkPictureImageFilter.cpp:58: //filterLevel is only serialized if pictureResolution is LocalSpace ...
6 years ago (2014-12-09 16:54:24 UTC) #5
reed1
need more time, will review after lunch
6 years ago (2014-12-09 16:59:53 UTC) #6
reed1
api lgtm
6 years ago (2014-12-09 20:06:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787073003/20001
6 years ago (2014-12-09 20:57:39 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-09 21:07:26 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f3c78ccf5694d22d2e4a7061a80399a7e69b59db

Powered by Google App Engine
This is Rietveld 408576698