Update geolocation permission tests for the permission bubble

chrome/browser/geolocation/geolocation_permission_context_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 
 #include <set>
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
+#include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/id_map.h"
 #include "base/memory/scoped_vector.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/simple_test_clock.h"
 #include "base/time/clock.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/geolocation/geolocation_permission_context_factory.h"
 #include "chrome/browser/infobars/infobar_service.h"
+#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
+#include "chrome/browser/ui/website_settings/permission_bubble_request.h"
+#include "chrome/browser/ui/website_settings/permission_bubble_view.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/content_settings/core/common/permission_request_id.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "components/infobars/core/infobar.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/mock_render_process_host.h"
 #include "content/public/test/test_renderer_host.h"
 #include "content/public/test/test_utils.h"
 #include "content/public/test/web_contents_tester.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(OS_ANDROID)
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/android/mock_google_location_settings_helper.h"
 #endif
 
 #if defined(ENABLE_EXTENSIONS)
 #include "extensions/browser/view_type_utils.h"
 #endif
 
 using content::MockRenderProcessHost;
 
+class MockPermissionBubbleView : public PermissionBubbleView {
+ public:
+  MockPermissionBubbleView() {}
+  virtual ~MockPermissionBubbleView() {}
+
+  virtual void SetDelegate(Delegate* delegate) override {
+  }
+  virtual void Show(
+      const std::vector<PermissionBubbleRequest*>& requests,
+      const std::vector<bool>& accept_state,
+      bool customization_mode) override {
+  }
+
+  virtual bool CanAcceptRequestUpdate() override {
+   return true;
+  }
+
+  virtual void Hide() override {
+  }
+
+  virtual bool IsVisible() override {
+   return false;
+  }
+};
 
 // ClosedInfoBarTracker -------------------------------------------------------
 
 // We need to track which infobars were closed.
 class ClosedInfoBarTracker : public content::NotificationObserver {
  public:
   ClosedInfoBarTracker();
   ~ClosedInfoBarTracker() override;
 
   // content::NotificationObserver:
@@ skipping 51 matching lines @@
   PermissionRequestID RequestIDForTab(int tab, int bridge_id);
   InfoBarService* infobar_service() {
     return InfoBarService::FromWebContents(web_contents());
   }
   InfoBarService* infobar_service_for_tab(int tab) {
     return InfoBarService::FromWebContents(extra_tabs_[tab]);
   }
 
   void RequestGeolocationPermission(content::WebContents* web_contents,
                                     const PermissionRequestID& id,
-                                    const GURL& requesting_frame);
-
+                                    const GURL& requesting_frame,
+                                    bool user_gesture);
   void PermissionResponse(const PermissionRequestID& id,
                           bool allowed);
   void CheckPermissionMessageSent(int bridge_id, bool allowed);
   void CheckPermissionMessageSentForTab(int tab, int bridge_id, bool allowed);
   void CheckPermissionMessageSentInternal(MockRenderProcessHost* process,
                                           int bridge_id,
                                           bool allowed);
   void AddNewTab(const GURL& url);
   void CheckTabContentsState(const GURL& requesting_frame,
                              ContentSetting expected_content_setting);
+  base::string16 GetFirstRequestText(PermissionBubbleManager* mgr);
+  int GetBubblesQueueSize(PermissionBubbleManager* mgr);
+  void AcceptBubble(PermissionBubbleManager* mgr);
+  void DenyBubble(PermissionBubbleManager* mgr);
+  void CloseBubble(PermissionBubbleManager* mgr);
+  void BubbleManagerDocumentLoadCompleted();
+  void BubbleManagerDocumentLoadCompleted(content::WebContents* web_contents);
 
   // owned by the browser context
   GeolocationPermissionContext* geolocation_permission_context_;
   ClosedInfoBarTracker closed_infobar_tracker_;
+  MockPermissionBubbleView bubble_view_;
   ScopedVector<content::WebContents> extra_tabs_;
 
   // A map between renderer child id and a pair represending the bridge id and
   // whether the requested permission was allowed.
   base::hash_map<int, std::pair<int, bool> > responses_;
 };
 
 PermissionRequestID GeolocationPermissionContextTests::RequestID(
     int bridge_id) {
   return PermissionRequestID(
       web_contents()->GetRenderProcessHost()->GetID(),
       web_contents()->GetRenderViewHost()->GetRoutingID(),
       bridge_id,
       GURL());
 }
 
 PermissionRequestID GeolocationPermissionContextTests::RequestIDForTab(
     int tab,
     int bridge_id) {
   return PermissionRequestID(
       extra_tabs_[tab]->GetRenderProcessHost()->GetID(),
       extra_tabs_[tab]->GetRenderViewHost()->GetRoutingID(),
       bridge_id,
       GURL());
 }
 
 void GeolocationPermissionContextTests::RequestGeolocationPermission(
     content::WebContents* web_contents,
     const PermissionRequestID& id,
-    const GURL& requesting_frame) {
+    const GURL& requesting_frame,
+    bool user_gesture) {
   geolocation_permission_context_->RequestPermission(
-      web_contents, id, requesting_frame, false,
+      web_contents, id, requesting_frame, user_gesture,
       base::Bind(&GeolocationPermissionContextTests::PermissionResponse,
                  base::Unretained(this), id));
-   content::RunAllBlockingPoolTasksUntilIdle();
+  content::RunAllBlockingPoolTasksUntilIdle();
 }
 
 void GeolocationPermissionContextTests::PermissionResponse(
     const PermissionRequestID& id,
     bool allowed) {
   responses_[id.render_process_id()] = std::make_pair(id.bridge_id(), allowed);
 }
 
 void GeolocationPermissionContextTests::CheckPermissionMessageSent(
     int bridge_id,
@@ skipping 26 matching lines @@
   new_tab->GetController().LoadURL(
       url, content::Referrer(), ui::PAGE_TRANSITION_TYPED, std::string());
   content::RenderFrameHostTester::For(new_tab->GetMainFrame())
       ->SendNavigate(extra_tabs_.size() + 1, url);
 
   // Set up required helpers, and make this be as "tabby" as the code requires.
 #if defined(ENABLE_EXTENSIONS)
   extensions::SetViewType(new_tab, extensions::VIEW_TYPE_TAB_CONTENTS);
 #endif
   InfoBarService::CreateForWebContents(new_tab);
+  PermissionBubbleManager::CreateForWebContents(new_tab);
+  PermissionBubbleManager::FromWebContents(new_tab)->SetView(
+      &bubble_view_);
 
   extra_tabs_.push_back(new_tab);
 }
 
 void GeolocationPermissionContextTests::CheckTabContentsState(
     const GURL& requesting_frame,
     ContentSetting expected_content_setting) {
   TabSpecificContentSettings* content_settings =
       TabSpecificContentSettings::FromWebContents(web_contents());
   const ContentSettingsUsagesState::StateMap& state_map =
@@ skipping 14 matching lines @@
 #if defined(ENABLE_EXTENSIONS)
   extensions::SetViewType(web_contents(), extensions::VIEW_TYPE_TAB_CONTENTS);
 #endif
   InfoBarService::CreateForWebContents(web_contents());
   TabSpecificContentSettings::CreateForWebContents(web_contents());
 #if defined(OS_ANDROID)
   MockGoogleLocationSettingsHelper::SetLocationStatus(true, true);
 #endif
   geolocation_permission_context_ =
       GeolocationPermissionContextFactory::GetForProfile(profile());
+  PermissionBubbleManager::CreateForWebContents(web_contents());
+  PermissionBubbleManager::FromWebContents(web_contents())->SetView(
+      &bubble_view_);
 }
 
 void GeolocationPermissionContextTests::TearDown() {
   extra_tabs_.clear();
   ChromeRenderViewHostTestHarness::TearDown();
 }
 
+base::string16 GeolocationPermissionContextTests::GetFirstRequestText(
+    PermissionBubbleManager* mgr) {

[Michael van Ouwerkerk, 2014/12/17 17:20:19]

s/mgr/manager/ -
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#General_Namin...

Here and below.

[felt, 2014/12/18 22:09:10]

Done.

+  return mgr->requests_.front()->GetMessageText();
+}
+
+int GeolocationPermissionContextTests::GetBubblesQueueSize(
+    PermissionBubbleManager* mgr) {
+  return static_cast<int>(mgr->requests_.size());
+}
+
+void GeolocationPermissionContextTests::AcceptBubble(
+    PermissionBubbleManager* mgr) {
+  mgr->Accept();
+}
+
+void GeolocationPermissionContextTests::DenyBubble(
+    PermissionBubbleManager* mgr) {
+  mgr->Deny();
+}
+
+void GeolocationPermissionContextTests::CloseBubble(
+    PermissionBubbleManager* mgr) {
+  mgr->Closing();
+}
+
+void GeolocationPermissionContextTests::BubbleManagerDocumentLoadCompleted() {
+  PermissionBubbleManager::FromWebContents(web_contents())->
+      DocumentOnLoadCompletedInMainFrame();
+}
+
+void GeolocationPermissionContextTests::BubbleManagerDocumentLoadCompleted(
+    content::WebContents* web_contents) {
+  PermissionBubbleManager::FromWebContents(web_contents)->
+      DocumentOnLoadCompletedInMainFrame();
+}
+
+// Needed to parameterize the tests for both infobars & permission bubbles.
+class GeolocationPermissionContextParamTests :
+      public GeolocationPermissionContextTests,
+      public ::testing::WithParamInterface<bool> {
+ protected:
+  GeolocationPermissionContextParamTests() {}
+  ~GeolocationPermissionContextParamTests() override {}
+
+  bool BubbleEnabled() {
+    return GetParam();
+  }
+
+  void SetUp() override {
+    GeolocationPermissionContextTests::SetUp();
+#if !defined(OS_ANDROID)
+    if (BubbleEnabled()) {
+      base::CommandLine::ForCurrentProcess()->AppendSwitch(
+          switches::kEnablePermissionsBubbles);
+      EXPECT_TRUE(PermissionBubbleManager::Enabled());
+    } else {
+      base::CommandLine::ForCurrentProcess()->AppendSwitch(
+          switches::kDisablePermissionsBubbles);
+      EXPECT_FALSE(PermissionBubbleManager::Enabled());
+    }
+#endif
+  }
+ private:
+  DISALLOW_COPY_AND_ASSIGN(GeolocationPermissionContextParamTests);
+};
+
 // Tests ----------------------------------------------------------------------
 
-TEST_F(GeolocationPermissionContextTests, SinglePermission) {
+TEST_P(GeolocationPermissionContextParamTests, SinglePermissionInfobar) {
+  if (BubbleEnabled()) return;
+
   GURL requesting_frame("http://www.example.com/geolocation");
   NavigateAndCommit(requesting_frame);
   EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), requesting_frame, true);
   ASSERT_EQ(1U, infobar_service()->infobar_count());
   infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
   ConfirmInfoBarDelegate* infobar_delegate =
       infobar->delegate()->AsConfirmInfoBarDelegate();
   ASSERT_TRUE(infobar_delegate);
   infobar_delegate->Cancel();
   infobar_service()->RemoveInfoBar(infobar);
   EXPECT_EQ(1U, closed_infobar_tracker_.size());
   EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar));
 }
 
-#if defined(OS_ANDROID)
-TEST_F(GeolocationPermissionContextTests, GeolocationEnabledDisabled) {
+TEST_P(GeolocationPermissionContextParamTests, SinglePermissionBubble) {
+  if (!BubbleEnabled()) return;
+
   GURL requesting_frame("http://www.example.com/geolocation");
   NavigateAndCommit(requesting_frame);
-  MockGoogleLocationSettingsHelper::SetLocationStatus(true, true);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);
-  EXPECT_EQ(1U, infobar_service()->infobar_count());
-  ConfirmInfoBarDelegate* infobar_delegate_0 =
-      infobar_service()->infobar_at(0)->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate_0);
-  base::string16 text_0 = infobar_delegate_0->GetButtonLabel(
-      ConfirmInfoBarDelegate::BUTTON_OK);
+  BubbleManagerDocumentLoadCompleted();
 
-  Reload();
-  MockGoogleLocationSettingsHelper::SetLocationStatus(true, false);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  PermissionBubbleManager* mgr =
+      PermissionBubbleManager::FromWebContents(web_contents());
+  EXPECT_EQ(0, GetBubblesQueueSize(mgr));
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), requesting_frame, true);
+  ASSERT_EQ(1, GetBubblesQueueSize(mgr));
 }
 
-TEST_F(GeolocationPermissionContextTests, MasterEnabledGoogleAppsEnabled) {
-  GURL requesting_frame("http://www.example.com/geolocation");
-  NavigateAndCommit(requesting_frame);
-  MockGoogleLocationSettingsHelper::SetLocationStatus(true, true);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);
-  EXPECT_EQ(1U, infobar_service()->infobar_count());
-  ConfirmInfoBarDelegate* infobar_delegate =
-      infobar_service()->infobar_at(0)->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate);
-  infobar_delegate->Accept();
-  CheckTabContentsState(requesting_frame, CONTENT_SETTING_ALLOW);
-  CheckPermissionMessageSent(0, true);
-}
-
-TEST_F(GeolocationPermissionContextTests, MasterEnabledGoogleAppsDisabled) {
-  GURL requesting_frame("http://www.example.com/geolocation");
-  NavigateAndCommit(requesting_frame);
-  MockGoogleLocationSettingsHelper::SetLocationStatus(true, false);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-}
-#endif
-
-TEST_F(GeolocationPermissionContextTests, QueuedPermission) {
+TEST_P(GeolocationPermissionContextParamTests, QueuedPermission) {
   GURL requesting_frame_0("http://www.example.com/geolocation");
   GURL requesting_frame_1("http://www.example-2.com/geolocation");
   EXPECT_EQ(CONTENT_SETTING_ASK,
             profile()->GetHostContentSettingsMap()->GetContentSetting(
                 requesting_frame_0, requesting_frame_0,
                 CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
   EXPECT_EQ(CONTENT_SETTING_ASK,
             profile()->GetHostContentSettingsMap()->GetContentSetting(
                 requesting_frame_1, requesting_frame_0,
                 CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
 
+  PermissionBubbleManager* mgr =
+      PermissionBubbleManager::FromWebContents(web_contents());
+  infobars::InfoBar* infobar_0;
+  infobars::InfoBar* infobar_1;
+  ConfirmInfoBarDelegate* infobar_delegate_0;
+  ConfirmInfoBarDelegate* infobar_delegate_1;
   NavigateAndCommit(requesting_frame_0);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
+
+  // Check that no permission requests have happened yet.
+  if (BubbleEnabled())
+    EXPECT_EQ(0, GetBubblesQueueSize(mgr));
+  else
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+
   // Request permission for two frames.
   RequestGeolocationPermission(
-      web_contents(), RequestID(0), requesting_frame_0);
+      web_contents(), RequestID(0), requesting_frame_0, BubbleEnabled());
   RequestGeolocationPermission(
-      web_contents(), RequestID(1), requesting_frame_1);
+      web_contents(), RequestID(1), requesting_frame_1, BubbleEnabled());
+
   // Ensure only one infobar is created.
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-  infobars::InfoBar* infobar_0 = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_0 =
-      infobar_0->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate_0);
-  base::string16 text_0 = infobar_delegate_0->GetMessageText();
+  base::string16 text_0;
+  if (BubbleEnabled()) {
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+    text_0 = GetFirstRequestText(mgr);
+  } else {
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+    infobar_0 = infobar_service()->infobar_at(0);
+    infobar_delegate_0 = infobar_0->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate_0);
+    text_0 = infobar_delegate_0->GetMessageText();
+  }
 
   // Accept the first frame.
-  infobar_delegate_0->Accept();
+  if (BubbleEnabled())
+    AcceptBubble(mgr);
+  else
+    infobar_delegate_0->Accept();
   CheckTabContentsState(requesting_frame_0, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(0, true);
+  if (!BubbleEnabled()) {
+    infobar_service()->RemoveInfoBar(infobar_0);
+    EXPECT_EQ(1U, closed_infobar_tracker_.size());
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_0));
+    closed_infobar_tracker_.Clear();
+  }
 
-  infobar_service()->RemoveInfoBar(infobar_0);
-  EXPECT_EQ(1U, closed_infobar_tracker_.size());
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_0));
-  closed_infobar_tracker_.Clear();
-  // Now we should have a new infobar for the second frame.
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
+  // Now we should have a new request for the second frame.
+  base::string16 text_1;
+  if (BubbleEnabled()) {
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+    text_1 = GetFirstRequestText(mgr);
+  } else {
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+    infobar_1 = infobar_service()->infobar_at(0);
+    infobar_delegate_1 = infobar_1->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate_1);
+    text_1 = infobar_delegate_1->GetMessageText();
+  }
 
-  infobars::InfoBar* infobar_1 = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_1 =
-      infobar_1->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate_1);
-  base::string16 text_1 = infobar_delegate_1->GetMessageText();
+  // Check that the messages differ.
   EXPECT_NE(text_0, text_1);
 
   // Cancel (block) this frame.
-  infobar_delegate_1->Cancel();
+  if (BubbleEnabled())
+    DenyBubble(mgr);
+   else
+    infobar_delegate_1->Cancel();
   CheckTabContentsState(requesting_frame_1, CONTENT_SETTING_BLOCK);
   CheckPermissionMessageSent(1, false);
-  infobar_service()->RemoveInfoBar(infobar_1);
-  EXPECT_EQ(1U, closed_infobar_tracker_.size());
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_1));
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  if (!BubbleEnabled()) {
+    infobar_service()->RemoveInfoBar(infobar_1);
+    EXPECT_EQ(1U, closed_infobar_tracker_.size());
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_1));
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+  }
+
   // Ensure the persisted permissions are ok.
   EXPECT_EQ(CONTENT_SETTING_ALLOW,
             profile()->GetHostContentSettingsMap()->GetContentSetting(
                 requesting_frame_0, requesting_frame_0,
                 CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
 
   EXPECT_EQ(CONTENT_SETTING_BLOCK,
             profile()->GetHostContentSettingsMap()->GetContentSetting(
                 requesting_frame_1, requesting_frame_0,
                 CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
 }
 
-TEST_F(GeolocationPermissionContextTests, HashIsIgnored) {
+TEST_P(GeolocationPermissionContextParamTests, HashIsIgnored) {
+  PermissionBubbleManager* mgr =
+      PermissionBubbleManager::FromWebContents(web_contents());
+  infobars::InfoBar* infobar;
+  ConfirmInfoBarDelegate* infobar_delegate;
+
   GURL url_a("http://www.example.com/geolocation#a");
   GURL url_b("http://www.example.com/geolocation#b");
 
-  // Navigate to the first url and check permission is requested.
+  // Navigate to the first url.
   NavigateAndCommit(url_a);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), url_a);
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-  infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate =
-      infobar->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate);
+  if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
+
+  // Check permission is requested.
+  if (BubbleEnabled()) {

[Michael van Ouwerkerk, 2014/12/17 17:20:19]

These kinds of branches make the code harder to read, and it seems fragile as
well. How about some helper methods like GetNumberOfPrompts that would
internally be something like:
if (BubbleEnabled())
  return GetBubblesQueueSize(mgr)
return infobar_service()->infobar_count()

[felt, 2014/12/18 22:09:09]

OK, I added a few helper methods. I think the code is simpler now in many
places.

+    ASSERT_EQ(0, GetBubblesQueueSize(mgr));
+    RequestGeolocationPermission(web_contents(), RequestID(0), url_a, true);
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+  } else {
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+    RequestGeolocationPermission(web_contents(), RequestID(0), url_a, false);
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+    infobar = infobar_service()->infobar_at(0);
+    infobar_delegate =
+        infobar->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate);
+  }
 
   // Change the hash, we'll still be on the same page.
   NavigateAndCommit(url_b);
+  if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
 
   // Accept.
-  infobar_delegate->Accept();
+  if (BubbleEnabled())
+    AcceptBubble(mgr);
+  else
+    infobar_delegate->Accept();
   CheckTabContentsState(url_a, CONTENT_SETTING_ALLOW);
   CheckTabContentsState(url_b, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(0, true);
 
   // Cleanup.
-  infobar_service()->RemoveInfoBar(infobar);
-  EXPECT_EQ(1U, closed_infobar_tracker_.size());
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar));
+  if (!BubbleEnabled()) {
+    infobar_service()->RemoveInfoBar(infobar);
+    EXPECT_EQ(1U, closed_infobar_tracker_.size());
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar));
+  }
 }
 
-TEST_F(GeolocationPermissionContextTests, PermissionForFileScheme) {
+TEST_P(GeolocationPermissionContextParamTests, PermissionForFileScheme) {
+  // TODO(felt): The bubble is rejecting file:// permission requests.
+  // Fix and enable this test.
+  if (BubbleEnabled()) return;
+
+  PermissionBubbleManager* mgr =
+      PermissionBubbleManager::FromWebContents(web_contents());
+  infobars::InfoBar* infobar;
+  ConfirmInfoBarDelegate* infobar_delegate;
+
   GURL requesting_frame("file://example/geolocation.html");
   NavigateAndCommit(requesting_frame);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);
-  EXPECT_EQ(1U, infobar_service()->infobar_count());
-  infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate =
-      infobar->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate);
+  if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
+
+  // Check permission is requested.
+  if (BubbleEnabled()) {
+    ASSERT_EQ(0, GetBubblesQueueSize(mgr));
+    RequestGeolocationPermission(
+        web_contents(), RequestID(0), requesting_frame, true);
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+  } else {
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+    RequestGeolocationPermission(
+        web_contents(), RequestID(0), requesting_frame, false);
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+    infobar = infobar_service()->infobar_at(0);
+    infobar_delegate = infobar->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate);
+  }
+
   // Accept the frame.
-  infobar_delegate->Accept();
+ if (BubbleEnabled())
+    AcceptBubble(mgr);
+  else
+    infobar_delegate->Accept();
   CheckTabContentsState(requesting_frame, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(0, true);
-  infobar_service()->RemoveInfoBar(infobar);
 
   // Make sure the setting is not stored.
   EXPECT_EQ(CONTENT_SETTING_ASK,
       profile()->GetHostContentSettingsMap()->GetContentSetting(
           requesting_frame,
           requesting_frame,
           CONTENT_SETTINGS_TYPE_GEOLOCATION,
           std::string()));
 }
 
-TEST_F(GeolocationPermissionContextTests, CancelGeolocationPermissionRequest) {
-  GURL requesting_frame_0("http://www.example.com/geolocation");
-  GURL requesting_frame_1("http://www.example-2.com/geolocation");
-  EXPECT_EQ(CONTENT_SETTING_ASK,
-            profile()->GetHostContentSettingsMap()->GetContentSetting(
-                requesting_frame_0, requesting_frame_0,
-                CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
-
-  EXPECT_EQ(CONTENT_SETTING_ASK,
-            profile()->GetHostContentSettingsMap()->GetContentSetting(
-                requesting_frame_1, requesting_frame_0,
-                CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
-
-  NavigateAndCommit(requesting_frame_0);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
+TEST_P(GeolocationPermissionContextParamTests,
+    CancelGeolocationPermissionRequest) {
+  GURL frame_0("http://www.example.com/geolocation");
+  GURL frame_1("http://www.example-2.com/geolocation");
+  PermissionBubbleManager* mgr =
+      PermissionBubbleManager::FromWebContents(web_contents());
+  EXPECT_EQ(CONTENT_SETTING_ASK,
+            profile()->GetHostContentSettingsMap()->GetContentSetting(
+                frame_0, frame_0,
+                CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
+
+  EXPECT_EQ(CONTENT_SETTING_ASK,
+            profile()->GetHostContentSettingsMap()->GetContentSetting(
+                frame_1, frame_0,
+                CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
+
+  NavigateAndCommit(frame_0);
+  if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
+
+  if (BubbleEnabled())
+    EXPECT_EQ(0, GetBubblesQueueSize(mgr));
+  else
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
 
   // Request permission for two frames.
   RequestGeolocationPermission(
-      web_contents(), RequestID(0), requesting_frame_0);
-  RequestGeolocationPermission(
-      web_contents(), RequestID(1), requesting_frame_1);
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-
-  infobars::InfoBar* infobar_0 = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_0 =
-      infobar_0->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate_0);
-  base::string16 text_0 = infobar_delegate_0->GetMessageText();
-
-  // Simulate the frame going away, ensure the infobar for this frame
-  // is removed and the next pending infobar is created.
-  geolocation_permission_context_->CancelPermissionRequest(web_contents(),
-      RequestID(0));
-  EXPECT_EQ(1U, closed_infobar_tracker_.size());
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_0));
-  closed_infobar_tracker_.Clear();
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-
-  infobars::InfoBar* infobar_1 = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_1 =
-      infobar_1->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate_1);
-  base::string16 text_1 = infobar_delegate_1->GetMessageText();
+      web_contents(), RequestID(0), frame_0, BubbleEnabled());
+  RequestGeolocationPermission(
+      web_contents(), RequestID(1), frame_1, BubbleEnabled());
+  if (BubbleEnabled())
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+  else
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+
+  // Get the first permission request text.
+  base::string16 text_0;
+  infobars::InfoBar* infobar_0;
+  if (BubbleEnabled()) {
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+    text_0 = GetFirstRequestText(mgr);
+  } else {
+    infobar_0 = infobar_service()->infobar_at(0);
+    ConfirmInfoBarDelegate* infobar_delegate_0 =
+        infobar_0->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate_0);
+    text_0 = infobar_delegate_0->GetMessageText();
+  }
+  ASSERT_NE(base::string16(), text_0);
+
+  // Simulate frame 0 going away; the request should be removed.
+  if (BubbleEnabled()) {
+    CloseBubble(mgr);
+  } else {
+    geolocation_permission_context_->CancelPermissionRequest(web_contents(),
+        RequestID(0));
+    EXPECT_EQ(1U, closed_infobar_tracker_.size());
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_0));
+    closed_infobar_tracker_.Clear();
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+  }
+
+  // Check that the next pending request is created correctly.
+  base::string16 text_1;
+  infobars::InfoBar* infobar_1;
+  ConfirmInfoBarDelegate* infobar_delegate_1;
+  if (BubbleEnabled()) {
+    base::string16 text_1 = GetFirstRequestText(mgr);
+  } else {
+    infobar_1 = infobar_service()->infobar_at(0);
+    infobar_delegate_1 = infobar_1->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate_1);
+    text_1 = infobar_delegate_1->GetMessageText();
+  }
   EXPECT_NE(text_0, text_1);
 
-  // Allow this frame.
-  infobar_delegate_1->Accept();
-  CheckTabContentsState(requesting_frame_1, CONTENT_SETTING_ALLOW);
+  // Allow this frame and check that it worked.
+  if (BubbleEnabled()) {
+    AcceptBubble(mgr);
+  } else {
+    infobar_delegate_1->Accept();
+    infobar_service()->RemoveInfoBar(infobar_1);
+    EXPECT_EQ(1U, closed_infobar_tracker_.size());
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_1));
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+  }
+  CheckTabContentsState(frame_1, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(1, true);
-  infobar_service()->RemoveInfoBar(infobar_1);
-  EXPECT_EQ(1U, closed_infobar_tracker_.size());
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_1));
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
+
   // Ensure the persisted permissions are ok.
   EXPECT_EQ(CONTENT_SETTING_ASK,
             profile()->GetHostContentSettingsMap()->GetContentSetting(
-                requesting_frame_0, requesting_frame_0,
+                frame_0, frame_0,
                 CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
 
   EXPECT_EQ(CONTENT_SETTING_ALLOW,
             profile()->GetHostContentSettingsMap()->GetContentSetting(
-                requesting_frame_1, requesting_frame_0,
-                CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
-}
-
-TEST_F(GeolocationPermissionContextTests, InvalidURL) {
+                frame_1, frame_0,
+                CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
+}
+
+TEST_P(GeolocationPermissionContextParamTests, InvalidURL) {
+  // Navigate to the first url.
   GURL invalid_embedder("about:blank");
   GURL requesting_frame;
   NavigateAndCommit(invalid_embedder);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
+
+  // Nothing should be displayed.
+  if (BubbleEnabled()) {
+    PermissionBubbleManager* mgr =
+        PermissionBubbleManager::FromWebContents(web_contents());
+    ASSERT_EQ(0, GetBubblesQueueSize(mgr));
+    RequestGeolocationPermission(
+        web_contents(), RequestID(0), requesting_frame, true);
+    ASSERT_EQ(0, GetBubblesQueueSize(mgr));
+  } else {
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+    RequestGeolocationPermission(
+        web_contents(), RequestID(0), requesting_frame, false);
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+  }
   CheckPermissionMessageSent(0, false);
 }
 
-TEST_F(GeolocationPermissionContextTests, SameOriginMultipleTabs) {
+TEST_P(GeolocationPermissionContextParamTests, SameOriginMultipleTabs) {
   GURL url_a("http://www.example.com/geolocation");
   GURL url_b("http://www.example-2.com/geolocation");
-  NavigateAndCommit(url_a);
-  AddNewTab(url_b);
-  AddNewTab(url_a);
-
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), url_a);
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-
-  RequestGeolocationPermission(extra_tabs_[0], RequestIDForTab(0, 0), url_b);
-  EXPECT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
-
-  RequestGeolocationPermission(extra_tabs_[1], RequestIDForTab(1, 0), url_a);
-  ASSERT_EQ(1U, infobar_service_for_tab(1)->infobar_count());
-
-  infobars::InfoBar* removed_infobar =
-      infobar_service_for_tab(1)->infobar_at(0);
-
-  // Accept the first tab.
-  infobars::InfoBar* infobar_0 = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_0 =
-      infobar_0->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate_0);
-  infobar_delegate_0->Accept();
+  NavigateAndCommit(url_a);  // Tab A0
+  AddNewTab(url_b);          // Tab B  (extra_tabs_[0])
+  AddNewTab(url_a);          // Tab A1 (extra_tabs_[1])
+  if (BubbleEnabled()) {
+    BubbleManagerDocumentLoadCompleted();
+    BubbleManagerDocumentLoadCompleted(extra_tabs_[0]);
+    BubbleManagerDocumentLoadCompleted(extra_tabs_[1]);
+  }
+  PermissionBubbleManager* mgr_a0 =
+      PermissionBubbleManager::FromWebContents(web_contents());
+  PermissionBubbleManager* mgr_b =
+      PermissionBubbleManager::FromWebContents(extra_tabs_[0]);
+  PermissionBubbleManager* mgr_a1 =
+      PermissionBubbleManager::FromWebContents(extra_tabs_[1]);
+
+  // Request permission in all three tabs.
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), url_a, BubbleEnabled());
+  RequestGeolocationPermission(
+      extra_tabs_[0], RequestIDForTab(0, 0), url_b, BubbleEnabled());
+  RequestGeolocationPermission(
+      extra_tabs_[1], RequestIDForTab(1, 0), url_a, BubbleEnabled());
+  infobars::InfoBar* infobar_a1;
+  if (BubbleEnabled()) {
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr_a0));
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr_b));
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr_a1));
+  } else {
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+    ASSERT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
+    ASSERT_EQ(1U, infobar_service_for_tab(1)->infobar_count());
+  }
+
+  // Accept the permission in tab A0.
+  if (BubbleEnabled()) {
+    AcceptBubble(mgr_a0);
+  } else {
+    infobars::InfoBar* infobar_a0 = infobar_service()->infobar_at(0);
+    infobar_a1 = infobar_service_for_tab(1)->infobar_at(0);  // Save for later.
+    ConfirmInfoBarDelegate* infobar_delegate_a0 =
+        infobar_a0->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate_a0);
+    infobar_delegate_a0->Accept();
+    infobar_service()->RemoveInfoBar(infobar_a0);
+    EXPECT_EQ(2U, closed_infobar_tracker_.size());
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_a0));
+  }
   CheckPermissionMessageSent(0, true);
-  infobar_service()->RemoveInfoBar(infobar_0);
-  EXPECT_EQ(2U, closed_infobar_tracker_.size());
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_0));
-  // Now the infobar for the tab with the same origin should have gone.
-  EXPECT_EQ(0U, infobar_service_for_tab(1)->infobar_count());
-  CheckPermissionMessageSentForTab(1, 0, true);
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(removed_infobar));
-  closed_infobar_tracker_.Clear();
-
-  // But the other tab should still have the info bar...
-  ASSERT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
-  infobars::InfoBar* infobar_1 = infobar_service_for_tab(0)->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_1 =
-      infobar_1->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate_1);
-  infobar_delegate_1->Cancel();
-  infobar_service_for_tab(0)->RemoveInfoBar(infobar_1);
-  EXPECT_EQ(1U, closed_infobar_tracker_.size());
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_1));
-}
-
-TEST_F(GeolocationPermissionContextTests, QueuedOriginMultipleTabs) {
+
+  // Because they're the same origin, this will cause tab A1's infobar to
+  // disappear. It does not cause the bubble to disappear: crbug.com/443013.
+  // TODO(felt): Update this test when the bubble's behavior is changed.
+  if (BubbleEnabled()) {
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr_a1));
+  } else {
+    CheckPermissionMessageSentForTab(1, 0, true);
+    ASSERT_EQ(0U, infobar_service_for_tab(1)->infobar_count());
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_a1));
+    closed_infobar_tracker_.Clear();
+  }
+
+  // Either way, tab B should still have a pending permission request.
+  if (BubbleEnabled())
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr_b));
+  else
+    ASSERT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
+}
+
+TEST_P(GeolocationPermissionContextParamTests, QueuedOriginMultipleTabs) {
   GURL url_a("http://www.example.com/geolocation");
   GURL url_b("http://www.example-2.com/geolocation");
-  NavigateAndCommit(url_a);
-  AddNewTab(url_a);
-
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), url_a);
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-
-  RequestGeolocationPermission(extra_tabs_[0], RequestIDForTab(0, 0), url_a);
-  EXPECT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
-
-  RequestGeolocationPermission(extra_tabs_[0], RequestIDForTab(0, 1), url_b);
-  ASSERT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
-
-  infobars::InfoBar* removed_infobar = infobar_service()->infobar_at(0);
-
-  // Accept the second tab.
-  infobars::InfoBar* infobar_0 = infobar_service_for_tab(0)->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_0 =
-      infobar_0->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate_0);
-  infobar_delegate_0->Accept();
+  NavigateAndCommit(url_a);  // Tab A0.
+  AddNewTab(url_a);          // Tab A1.
+  if (BubbleEnabled()) {
+    BubbleManagerDocumentLoadCompleted();
+    BubbleManagerDocumentLoadCompleted(extra_tabs_[0]);
+  }
+  PermissionBubbleManager* mgr_a0 =
+      PermissionBubbleManager::FromWebContents(web_contents());
+  PermissionBubbleManager* mgr_a1 =
+      PermissionBubbleManager::FromWebContents(extra_tabs_[0]);
+  infobars::InfoBar* infobar_a0;
+
+  // Request permission in both tabs; the extra tab will have two permission
+  // requests from two origins.
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), url_a, BubbleEnabled());
+  RequestGeolocationPermission(
+      extra_tabs_[0], RequestIDForTab(0, 0), url_a, BubbleEnabled());
+  RequestGeolocationPermission(
+      extra_tabs_[0], RequestIDForTab(0, 1), url_b, BubbleEnabled());
+  if (BubbleEnabled()) {
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr_a0));
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr_a1));
+  } else {
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+    ASSERT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
+    infobar_a0 = infobar_service()->infobar_at(0);  // Save for later.
+  }
+
+  // Accept the first request in tab A1.
+  if (BubbleEnabled()) {
+    AcceptBubble(mgr_a1);
+  } else {
+    infobars::InfoBar* infobar_a1 = infobar_service_for_tab(0)->infobar_at(0);
+    ConfirmInfoBarDelegate* infobar_delegate_a1 =
+        infobar_a1->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate_a1);
+    infobar_delegate_a1->Accept();
+    infobar_service_for_tab(0)->RemoveInfoBar(infobar_a1);
+    EXPECT_EQ(2U, closed_infobar_tracker_.size());
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_a1));
+  }
   CheckPermissionMessageSentForTab(0, 0, true);
-  infobar_service_for_tab(0)->RemoveInfoBar(infobar_0);
-  EXPECT_EQ(2U, closed_infobar_tracker_.size());
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_0));
-  // Now the infobar for the tab with the same origin should have gone.
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  CheckPermissionMessageSent(0, true);
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(removed_infobar));
-  closed_infobar_tracker_.Clear();
-
-  // And we should have the queued infobar displayed now.
-  ASSERT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
-
-  // Accept the second infobar.
-  infobars::InfoBar* infobar_1 = infobar_service_for_tab(0)->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_1 =
-      infobar_1->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate_1);
-  infobar_delegate_1->Accept();
+
+  // Because they're the same origin, this will cause tab A0's infobar to
+  // disappear. It does not cause the bubble to disappear: crbug.com/443013.
+  // TODO(felt): Update this test when the bubble's behavior is changed.
+  if (BubbleEnabled()) {
+    EXPECT_EQ(1, GetBubblesQueueSize(mgr_a0));
+  } else {
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+    CheckPermissionMessageSent(0, true);
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_a0));
+    closed_infobar_tracker_.Clear();
+  }
+
+  // The second request should now be visible in tab A1.
+  if (BubbleEnabled())
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr_a1));
+  else
+    ASSERT_EQ(1U, infobar_service_for_tab(0)->infobar_count());
+
+  // Accept the second request and check that it's gone.
+  if (BubbleEnabled()) {
+    AcceptBubble(mgr_a1);
+    EXPECT_EQ(0, GetBubblesQueueSize(mgr_a1));
+  } else {
+    infobars::InfoBar* infobar_1 = infobar_service_for_tab(0)->infobar_at(0);
+    ConfirmInfoBarDelegate* infobar_delegate_1 =
+        infobar_1->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate_1);
+    infobar_delegate_1->Accept();
+    infobar_service_for_tab(0)->RemoveInfoBar(infobar_1);
+    EXPECT_EQ(1U, closed_infobar_tracker_.size());
+    EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_1));
+  }
   CheckPermissionMessageSentForTab(0, 1, true);
-  infobar_service_for_tab(0)->RemoveInfoBar(infobar_1);
-  EXPECT_EQ(1U, closed_infobar_tracker_.size());
-  EXPECT_TRUE(closed_infobar_tracker_.Contains(infobar_1));
-}
-
-TEST_F(GeolocationPermissionContextTests, TabDestroyed) {
+}
+
+TEST_P(GeolocationPermissionContextParamTests, TabDestroyed) {
+  PermissionBubbleManager* mgr =
+      PermissionBubbleManager::FromWebContents(web_contents());
   GURL requesting_frame_0("http://www.example.com/geolocation");
   GURL requesting_frame_1("http://www.example-2.com/geolocation");
   EXPECT_EQ(CONTENT_SETTING_ASK,
             profile()->GetHostContentSettingsMap()->GetContentSetting(
                 requesting_frame_0, requesting_frame_0,
                 CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
 
   EXPECT_EQ(CONTENT_SETTING_ASK,
             profile()->GetHostContentSettingsMap()->GetContentSetting(
                 requesting_frame_1, requesting_frame_0,
                 CONTENT_SETTINGS_TYPE_GEOLOCATION, std::string()));
 
   NavigateAndCommit(requesting_frame_0);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
+
+  if (BubbleEnabled())
+    EXPECT_EQ(0, GetBubblesQueueSize(mgr));
+  else
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+
   // Request permission for two frames.
   RequestGeolocationPermission(
-      web_contents(), RequestID(0), requesting_frame_0);
+      web_contents(), RequestID(0), requesting_frame_0, false);
   RequestGeolocationPermission(
-      web_contents(), RequestID(1), requesting_frame_1);
-  // Ensure only one infobar is created.
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-  infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
+      web_contents(), RequestID(1), requesting_frame_1, false);
 
-  // Delete the tab contents.
-  DeleteContents();
+  // Ensure only one infobar/bubble is created.
+  if (BubbleEnabled())
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+  else
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
 
-  // During contents destruction, the infobar will have been closed, and the
-  // pending request should have been cleared without an infobar being created.
-  ASSERT_EQ(1U, closed_infobar_tracker_.size());
-  ASSERT_TRUE(closed_infobar_tracker_.Contains(infobar));
+  // Delete the tab contents and check that the infobar/bubble was removed.
+  if (BubbleEnabled()) {
+    DeleteContents();
+    ASSERT_EQ(0, GetBubblesQueueSize(mgr));
+  } else {
+    infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
+    DeleteContents();
+    ASSERT_EQ(1U, closed_infobar_tracker_.size());
+    ASSERT_TRUE(closed_infobar_tracker_.Contains(infobar));
+  }
 }
 
-TEST_F(GeolocationPermissionContextTests, LastUsageAudited) {
+TEST_P(GeolocationPermissionContextParamTests, LastUsageAudited) {
+  PermissionBubbleManager* mgr =
+      PermissionBubbleManager::FromWebContents(web_contents());
   GURL requesting_frame("http://www.example.com/geolocation");
   NavigateAndCommit(requesting_frame);
+  if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
 
   base::SimpleTestClock* test_clock = new base::SimpleTestClock;
   test_clock->SetNow(base::Time::UnixEpoch() +
                      base::TimeDelta::FromSeconds(10));
 
   HostContentSettingsMap* map = profile()->GetHostContentSettingsMap();
   map->SetPrefClockForTesting(scoped_ptr<base::Clock>(test_clock));
 
   // The permission shouldn't have been used yet.
   EXPECT_EQ(map->GetLastUsage(requesting_frame.GetOrigin(),
                               requesting_frame.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             0);
 
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
-  RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-  infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate =
-      infobar->delegate()->AsConfirmInfoBarDelegate();
-  ASSERT_TRUE(infobar_delegate);
-  infobar_delegate->Accept();
+  if (BubbleEnabled())
+    EXPECT_EQ(0, GetBubblesQueueSize(mgr));
+  else
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), requesting_frame, false);
+  if (BubbleEnabled()) {
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+    AcceptBubble(mgr);
+  } else {
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+    infobars::InfoBar* infobar = infobar_service()->infobar_at(0);
+    ConfirmInfoBarDelegate* infobar_delegate =
+        infobar->delegate()->AsConfirmInfoBarDelegate();
+    ASSERT_TRUE(infobar_delegate);
+    infobar_delegate->Accept();
+  }
   CheckTabContentsState(requesting_frame, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(0, true);
 
   // Permission has been used at the starting time.
   EXPECT_EQ(map->GetLastUsage(requesting_frame.GetOrigin(),
                               requesting_frame.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             10);
 
   test_clock->Advance(base::TimeDelta::FromSeconds(3));
-  RequestGeolocationPermission(web_contents(), RequestID(0), requesting_frame);
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), requesting_frame, false);
 
   // Permission has been used three seconds later.
   EXPECT_EQ(map->GetLastUsage(requesting_frame.GetOrigin(),
                               requesting_frame.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             13);
 }
 
-TEST_F(GeolocationPermissionContextTests, LastUsageAuditedMultipleFrames) {
+TEST_P(GeolocationPermissionContextParamTests, LastUsageAuditedMultipleFrames) {
+  PermissionBubbleManager* mgr =
+      PermissionBubbleManager::FromWebContents(web_contents());
   base::SimpleTestClock* test_clock = new base::SimpleTestClock;
   test_clock->SetNow(base::Time::UnixEpoch() +
                      base::TimeDelta::FromSeconds(10));
 
   HostContentSettingsMap* map = profile()->GetHostContentSettingsMap();
   map->SetPrefClockForTesting(scoped_ptr<base::Clock>(test_clock));
 
   GURL requesting_frame_0("http://www.example.com/geolocation");
   GURL requesting_frame_1("http://www.example-2.com/geolocation");
 
   // The permission shouldn't have been used yet.
   EXPECT_EQ(map->GetLastUsage(requesting_frame_0.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             0);
   EXPECT_EQ(map->GetLastUsage(requesting_frame_1.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             0);
 
   NavigateAndCommit(requesting_frame_0);
-  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  if (BubbleEnabled()) BubbleManagerDocumentLoadCompleted();
+
+  if (BubbleEnabled())
+    EXPECT_EQ(0, GetBubblesQueueSize(mgr));
+  else
+    EXPECT_EQ(0U, infobar_service()->infobar_count());
 
   // Request permission for two frames.
   RequestGeolocationPermission(
-      web_contents(), RequestID(0), requesting_frame_0);
+      web_contents(), RequestID(0), requesting_frame_0, false);
   RequestGeolocationPermission(
-      web_contents(), RequestID(1), requesting_frame_1);
+      web_contents(), RequestID(1), requesting_frame_1, false);
 
-  // Ensure only one infobar is created.
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-  infobars::InfoBar* infobar_0 = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_0 =
-      infobar_0->delegate()->AsConfirmInfoBarDelegate();
+  // Ensure only one request is created.
+  infobars::InfoBar* infobar_0;
+  ConfirmInfoBarDelegate* infobar_delegate_0;
+  if (BubbleEnabled()) {
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+  } else {
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+    infobar_0 = infobar_service()->infobar_at(0);
+    infobar_delegate_0 = infobar_0->delegate()->AsConfirmInfoBarDelegate();
+  }
 
   // Accept the first frame.
-  infobar_delegate_0->Accept();
+  if (BubbleEnabled()) {
+    AcceptBubble(mgr);
+  } else {
+    infobar_delegate_0->Accept();
+    infobar_service()->RemoveInfoBar(infobar_0);
+  }
   CheckTabContentsState(requesting_frame_0, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(0, true);
-  infobar_service()->RemoveInfoBar(infobar_0);
 
   // Verify that accepting the first didn't accept because it's embedder
   // in the other.
   EXPECT_EQ(map->GetLastUsage(requesting_frame_0.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             10);
   EXPECT_EQ(map->GetLastUsage(requesting_frame_1.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             0);
 
-  ASSERT_EQ(1U, infobar_service()->infobar_count());
-  infobars::InfoBar* infobar_1 = infobar_service()->infobar_at(0);
-  ConfirmInfoBarDelegate* infobar_delegate_1 =
-      infobar_1->delegate()->AsConfirmInfoBarDelegate();
+  infobars::InfoBar* infobar_1;
+  ConfirmInfoBarDelegate* infobar_delegate_1;
+  if (BubbleEnabled()) {
+    ASSERT_EQ(1, GetBubblesQueueSize(mgr));
+  } else {
+    ASSERT_EQ(1U, infobar_service()->infobar_count());
+    infobar_1 = infobar_service()->infobar_at(0);
+    infobar_delegate_1 = infobar_1->delegate()->AsConfirmInfoBarDelegate();
+  }
 
   test_clock->Advance(base::TimeDelta::FromSeconds(1));
 
   // Allow the second frame.
-  infobar_delegate_1->Accept();
+  if (BubbleEnabled()) {
+    AcceptBubble(mgr);
+  } else {
+    infobar_delegate_1->Accept();
+    infobar_service()->RemoveInfoBar(infobar_1);
+  }
   CheckTabContentsState(requesting_frame_1, CONTENT_SETTING_ALLOW);
   CheckPermissionMessageSent(1, true);
-  infobar_service()->RemoveInfoBar(infobar_1);
 
   // Verify that the times are different.
   EXPECT_EQ(map->GetLastUsage(requesting_frame_0.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             10);
   EXPECT_EQ(map->GetLastUsage(requesting_frame_1.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             11);
 
   test_clock->Advance(base::TimeDelta::FromSeconds(2));
   RequestGeolocationPermission(
-      web_contents(), RequestID(0), requesting_frame_0);
+      web_contents(), RequestID(0), requesting_frame_0, false);
 
   // Verify that requesting permission in one frame doesn't update other where
   // it is the embedder.
   EXPECT_EQ(map->GetLastUsage(requesting_frame_0.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             13);
   EXPECT_EQ(map->GetLastUsage(requesting_frame_1.GetOrigin(),
                               requesting_frame_0.GetOrigin(),
                               CONTENT_SETTINGS_TYPE_GEOLOCATION).ToDoubleT(),
             11);
 }
+
+INSTANTIATE_TEST_CASE_P(GeolocationPermissionContextTestsWithAndWithoutBubbles,
+                        GeolocationPermissionContextParamTests,
+                        ::testing::Values(false, true));
+
+// Infobar-only tests ----------------------------------------------------------
+// Android doesn't support permission bubbles.
+
+#if defined(OS_ANDROID)
+TEST_F(GeolocationPermissionContextTests, GeolocationEnabledDisabled) {
+  EXPECT_FALSE(PermissionBubbleManager::Enabled());
+  GURL requesting_frame("http://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
+  MockGoogleLocationSettingsHelper::SetLocationStatus(true, true);
+  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), requesting_frame, true);
+  EXPECT_EQ(1U, infobar_service()->infobar_count());
+  ConfirmInfoBarDelegate* infobar_delegate_0 =
+      infobar_service()->infobar_at(0)->delegate()->AsConfirmInfoBarDelegate();
+  ASSERT_TRUE(infobar_delegate_0);
+  base::string16 text_0 = infobar_delegate_0->GetButtonLabel(
+      ConfirmInfoBarDelegate::BUTTON_OK);
+
+  Reload();
+  MockGoogleLocationSettingsHelper::SetLocationStatus(true, false);
+  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), requesting_frame, true);
+  EXPECT_EQ(0U, infobar_service()->infobar_count());
+}
+
+TEST_F(GeolocationPermissionContextTests, MasterEnabledGoogleAppsEnabled) {
+  EXPECT_FALSE(PermissionBubbleManager::Enabled());
+  GURL requesting_frame("http://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
+  MockGoogleLocationSettingsHelper::SetLocationStatus(true, true);
+  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), requesting_frame, true);
+  EXPECT_EQ(1U, infobar_service()->infobar_count());
+  ConfirmInfoBarDelegate* infobar_delegate =
+      infobar_service()->infobar_at(0)->delegate()->AsConfirmInfoBarDelegate();
+  ASSERT_TRUE(infobar_delegate);
+  infobar_delegate->Accept();
+  CheckTabContentsState(requesting_frame, CONTENT_SETTING_ALLOW);
+  CheckPermissionMessageSent(0, true);
+}
+
+TEST_F(GeolocationPermissionContextTests, MasterEnabledGoogleAppsDisabled) {
+  EXPECT_FALSE(PermissionBubbleManager::Enabled());
+  GURL requesting_frame("http://www.example.com/geolocation");
+  NavigateAndCommit(requesting_frame);
+  MockGoogleLocationSettingsHelper::SetLocationStatus(true, false);
+  EXPECT_EQ(0U, infobar_service()->infobar_count());
+  RequestGeolocationPermission(
+      web_contents(), RequestID(0), requesting_frame, true);
+  EXPECT_EQ(0U, infobar_service()->infobar_count());
+}
+#endif