Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 787023002: Upstream more layers, decoration title, layer_title_cache (Closed)

Created:
6 years ago by Changwan Ryu
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream more layers, decoration title, layer_title_cache BUG=426119, 437750 Committed: https://crrev.com/7f84b4cf686a5fc6e523f4f4bf3e750064dbc21c Cr-Commit-Position: refs/heads/master@{#309521}

Patch Set 1 #

Total comments: 2

Patch Set 2 : upstream resources as well #

Total comments: 8

Patch Set 3 : removed unused ui resource provider references #

Total comments: 2

Patch Set 4 : rebased #

Patch Set 5 : updated creation year #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2294 lines, -0 lines) Patch
A chrome/android/java/res/drawable-hdpi/spinner.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-hdpi/spinner_white.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/spinner.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-mdpi/spinner_white.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/spinner.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xhdpi/spinner_white.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/spinner.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxhdpi/spinner_white.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/spinner.png View 1 Binary file 0 comments Download
A chrome/android/java/res/drawable-xxxhdpi/spinner_white.png View 1 Binary file 0 comments Download
M chrome/android/java/res/values-sw600dp/dimens.xml View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java View 1 2 3 4 1 chunk +150 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/compositor/TitleCache.java View 1 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/decoration_title.h View 1 2 1 chunk +97 lines, -0 lines 1 comment Download
A chrome/browser/android/compositor/decoration_title.cc View 1 2 1 chunk +243 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer/content_layer.h View 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer/content_layer.cc View 1 chunk +246 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer/contextual_search_layer.h View 1 chunk +83 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer/contextual_search_layer.cc View 1 2 3 4 1 chunk +271 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer/tab_layer.h View 1 2 3 4 1 chunk +141 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer/tab_layer.cc View 1 1 chunk +583 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer/toolbar_layer.h View 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer/toolbar_layer.cc View 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer_title_cache.h View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
A chrome/browser/android/compositor/layer_title_cache.cc View 1 2 3 1 chunk +125 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Changwan Ryu
6 years ago (2014-12-09 12:31:50 UTC) #2
Jaekyun Seok (inactive)
https://chrome-internal-review.googlesource.com/#/c/187415/2 will be landed soon. Please apply its change here. https://codereview.chromium.org/787023002/diff/20001/chrome/browser/android/compositor/decoration_title.cc File chrome/browser/android/compositor/decoration_title.cc (right): https://codereview.chromium.org/787023002/diff/20001/chrome/browser/android/compositor/decoration_title.cc#newcode14 ...
6 years ago (2014-12-11 01:31:04 UTC) #3
Changwan Ryu
https://codereview.chromium.org/787023002/diff/20001/chrome/browser/android/compositor/decoration_title.cc File chrome/browser/android/compositor/decoration_title.cc (right): https://codereview.chromium.org/787023002/diff/20001/chrome/browser/android/compositor/decoration_title.cc#newcode14 chrome/browser/android/compositor/decoration_title.cc:14: #include "content/public/browser/android/ui_resource_provider.h" On 2014/12/11 01:31:04, Jaekyun Seok wrote: > ...
6 years ago (2014-12-11 04:12:33 UTC) #4
Changwan Ryu
On 2014/12/11 04:12:33, Changwan Ryu wrote: > https://codereview.chromium.org/787023002/diff/20001/chrome/browser/android/compositor/decoration_title.cc > File chrome/browser/android/compositor/decoration_title.cc (right): > > https://codereview.chromium.org/787023002/diff/20001/chrome/browser/android/compositor/decoration_title.cc#newcode14 ...
6 years ago (2014-12-11 23:09:42 UTC) #5
David Trainor- moved to gerrit
lgtm, but wait for Pedro's downstream change that touches the contextual search layers please! https://codereview.chromium.org/787023002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java ...
6 years ago (2014-12-16 01:23:33 UTC) #6
Changwan Ryu
https://codereview.chromium.org/787023002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java (right): https://codereview.chromium.org/787023002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java#newcode1 chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java:1: // Copyright 2011 The Chromium Authors. All rights reserved. ...
6 years ago (2014-12-23 01:27:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787023002/80001
6 years ago (2014-12-23 01:28:23 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-23 02:19:06 UTC) #10
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/7f84b4cf686a5fc6e523f4f4bf3e750064dbc21c Cr-Commit-Position: refs/heads/master@{#309521}
6 years ago (2014-12-23 02:19:54 UTC) #11
Nico
5 years, 5 months ago (2015-07-22 18:12:14 UTC) #13
Message was sent while issue was closed. 
https://codereview.chromium.org/787023002/diff/80001/chrome/browser/android/c...
File chrome/browser/android/compositor/decoration_title.h (right):

https://codereview.chromium.org/787023002/diff/80001/chrome/browser/android/c...
chrome/browser/android/compositor/decoration_title.h:31: class DecorationTitle {
(A short class comment describing what this does would've saved me 30s today.
All the other android browser compositor classes I looked at so far have have
excellent class comments, so kudos for that!)

Powered by Google App Engine
This is Rietveld 408576698