Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 787013005: Only presubmit warn when spammy logging is being added/modified. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
jamesr, esprehn, eseidel
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Only presubmit warn when spammy logging is being added/modified. Sky has a bunch of printfs that are only used for efficient local debugging. Don't presubmit warn when a file that contains one of these is modified unless the patch actually modifies them. Do this by changing the presubmit to only look at the "+" lines in the diff (which is what ChangedContents returns). R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d77dcf8b243f9dd19df7ee0b6d5db3a1a1e30f34

Patch Set 1 #

Patch Set 2 : use ChangedContents #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M PRESUBMIT.py View 1 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ojan
6 years ago (2014-12-09 17:18:02 UTC) #2
ojan
Oh, now I see that the normal way to do this is use ChangedContents. I'll ...
6 years ago (2014-12-09 17:21:05 UTC) #3
ojan
OK. Ready for review.
6 years ago (2014-12-09 17:30:02 UTC) #4
eseidel
I think we can test presubmits. Last I knew there was a PRESUBMIT_test.py. Hard to ...
6 years ago (2014-12-09 18:46:36 UTC) #5
ojan
6 years ago (2014-12-09 21:18:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d77dcf8b243f9dd19df7ee0b6d5db3a1a1e30f34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698