Hide the proxy socket address from the clients of ProxyResolvingClientSocket.

Hide the proxy socket address from the clients of ProxyResolvingClientSocket.

BUG=webrtc:3868
Committed: https://crrev.com/c5f656f044af0a3eaf5d8190bb9bc5abd43344b7
Cr-Commit-Position: refs/heads/master@{#307972}

[jiayl, 2014-12-11 17:49:20]

jiayl@chromium.org changed reviewers:
+ juberti@chromium.org, sergeyu@chromium.org

[jiayl, 2014-12-11 17:49:20]

PTAL

[Sergey Ulanov, 2014-12-11 19:09:17]

lgtm

https://codereview.chromium.org/787003004/diff/1/content/renderer/p2p/ipc_soc...
File content/renderer/p2p/ipc_socket_factory.cc (right):

https://codereview.chromium.org/787003004/diff/1/content/renderer/p2p/ipc_soc...
content/renderer/p2p/ipc_socket_factory.cc:543: VLOG(3) << "Failed to convert
remote IPEndPoint to SocketAddress: "
Do we need to log it at all if it's expected?

[jiayl, 2014-12-11 19:19:41]

On 2014/12/11 19:09:17, Sergey Ulanov wrote:
> lgtm
> 
>
https://codereview.chromium.org/787003004/diff/1/content/renderer/p2p/ipc_soc...
> File content/renderer/p2p/ipc_socket_factory.cc (right):
> 
>
https://codereview.chromium.org/787003004/diff/1/content/renderer/p2p/ipc_soc...
> content/renderer/p2p/ipc_socket_factory.cc:543: VLOG(3) << "Failed to convert
> remote IPEndPoint to SocketAddress: "
> Do we need to log it at all if it's expected?

I was on the fence. Removed.

[jiayl, 2014-12-11 19:19:50]

The CQ bit was checked by jiayl@chromium.org

[commit-bot: I haz the power, 2014-12-11 19:20:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787003004/20001

[juberti2, 2014-12-11 19:23:51]

lgtm % nits

https://codereview.chromium.org/787003004/diff/1/content/renderer/p2p/ipc_soc...
File content/renderer/p2p/ipc_socket_factory.cc (right):

https://codereview.chromium.org/787003004/diff/1/content/renderer/p2p/ipc_soc...
content/renderer/p2p/ipc_socket_factory.cc:402: address_chrome =
net::IPEndPoint(net::IPAddressNumber(), address.port());
I think we should check that address == remote_address_, to ensure any weird
stuff fails.
Also maybe ensure this is a TCP connection.

https://codereview.chromium.org/787003004/diff/1/content/renderer/p2p/ipc_soc...
content/renderer/p2p/ipc_socket_factory.cc:543: VLOG(3) << "Failed to convert
remote IPEndPoint to SocketAddress: "
On 2014/12/11 19:09:17, Sergey Ulanov wrote:
> Do we need to log it at all if it's expected?

agree, we should probably not even try this step if remote_address is empty

https://codereview.chromium.org/787003004/diff/1/content/renderer/p2p/ipc_soc...
content/renderer/p2p/ipc_socket_factory.cc:608: if (address.address().empty()) {
check that this only happens for TCP connections?

[jiayl, 2014-12-11 19:27:28]

The CQ bit was unchecked by jiayl@chromium.org

[jiayl, 2014-12-11 19:32:06]

The CQ bit was checked by jiayl@chromium.org

[commit-bot: I haz the power, 2014-12-11 19:33:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787003004/40001

[commit-bot: I haz the power, 2014-12-11 21:03:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-11 21:04:43]

Patchset 3 (id:??) landed as
https://crrev.com/c5f656f044af0a3eaf5d8190bb9bc5abd43344b7
Cr-Commit-Position: refs/heads/master@{#307972}