Issue 787003003: Include SkTypes.h from SkDynamicAnnotations.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 787003003: Include SkTypes.h from SkDynamicAnnotations.h (Closed)

Created:
6 years ago by mtklein_C

Modified:
6 years ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Include SkTypes.h from SkDynamicAnnotations.h This allows us to control SK_DYNAMIC_ANNOTATIONS_ENABLED by Sk*Config.h files. This is a no-op today, because we control it from the compiler command line. BUG=430815 Committed: https://skia.googlesource.com/skia/+/59f939eda6b43e5367d2ca80806b51bc4709c554

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	include/core/SkDynamicAnnotations.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787003003/1

6 years ago (2014-12-10 18:40:25 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-10 18:49:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/59f939eda6b43e5367d2ca80806b51bc4709c554