Issue 7870003: Guard against rare case of allocation failure during evacuation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7870003: Guard against rare case of allocation failure during evacuation. (Closed)

Created:
9 years, 3 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 3 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Guard against rare case of allocation failure during evacuation. This fixes flakiness of mjsunit/regress/regress-524 (crash always reproducible with --always-compact). R=erik.corry@gmail.com BUG=v8:1556 Committed: http://code.google.com/p/v8/source/detail?r=9251

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -10 lines)			Patch
M	src/mark-compact.cc	View	3 chunks	+30 lines, -8 lines	0 comments	Download
M	src/spaces.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/spaces.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 3 months ago (2011-09-13 07:10:21 UTC) #2

LGTM, but after each GC we set a limit for the growth of the old space to
trigger the next GC.  Perhaps we should set this limit lower than the max size
in order to have space to compact?

Expand Messages | Collapse Messages