Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 786993002: Generalize V4L2 HW video codec device names (Closed)

Created:
6 years ago by henryhsu
Modified:
6 years ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Generalize V4L2 HW video codec device names Switch to more generalized V4L2 video accelerator device names and update sandbox rules to reflect that. After video_ChromeHWDecodeUsed autotest is fixed, this cl is submitted again due to crrev.com/730693005 reverted in crrev.com/784553004. BUG=405861, 437598, 439175 TEST=passed video_ChromeHWDecodeUsed with h264 and vp8 on peach_pit. Media.GpuVideoDecoderInitializeStatus value is 0 when playing a video from youtube. DUT only has /dev/video-enc and /dev/video-dec device nodes. Committed: https://crrev.com/b777ad3f16655a3493a0ecd9975c58a7b84c740d Cr-Commit-Position: refs/heads/master@{#307674}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nits #

Total comments: 1

Patch Set 3 : address review commments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -307 lines) Patch
D content/common/gpu/media/exynos_v4l2_video_device.h View 1 chunk +0 lines, -58 lines 0 comments Download
D content/common/gpu/media/exynos_v4l2_video_device.cc View 1 chunk +0 lines, -211 lines 0 comments Download
A + content/common/gpu/media/generic_v4l2_video_device.h View 1 2 chunks +9 lines, -9 lines 0 comments Download
A + content/common/gpu/media/generic_v4l2_video_device.cc View 8 chunks +17 lines, -17 lines 0 comments Download
M content/common/gpu/media/v4l2_video_device.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc View 1 2 1 chunk +8 lines, -6 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
henryhsu
jorgelo@chromium.org: Please review changes in posciak@chromium.org: Please review changes in PTAL
6 years ago (2014-12-09 08:30:38 UTC) #2
Pawel Osciak
lgtm % nits, also please update CL description. https://codereview.chromium.org/786993002/diff/1/content/common/gpu/media/generic_v4l2_video_device.h File content/common/gpu/media/generic_v4l2_video_device.h (right): https://codereview.chromium.org/786993002/diff/1/content/common/gpu/media/generic_v4l2_video_device.h#newcode6 content/common/gpu/media/generic_v4l2_video_device.h:6: // ...
6 years ago (2014-12-09 08:33:50 UTC) #3
henryhsu
PTAL https://codereview.chromium.org/786993002/diff/1/content/common/gpu/media/generic_v4l2_video_device.h File content/common/gpu/media/generic_v4l2_video_device.h (right): https://codereview.chromium.org/786993002/diff/1/content/common/gpu/media/generic_v4l2_video_device.h#newcode6 content/common/gpu/media/generic_v4l2_video_device.h:6: // Generic platform. On 2014/12/09 08:33:49, Pawel Osciak ...
6 years ago (2014-12-09 08:42:58 UTC) #4
Pawel Osciak
On 2014/12/09 08:42:58, henryhsu wrote: > PTAL > > https://codereview.chromium.org/786993002/diff/1/content/common/gpu/media/generic_v4l2_video_device.h > File content/common/gpu/media/generic_v4l2_video_device.h (right): > ...
6 years ago (2014-12-09 08:47:04 UTC) #5
Jorge Lucangeli Obes
https://codereview.chromium.org/786993002/diff/20001/content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc File content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc (right): https://codereview.chromium.org/786993002/diff/20001/content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc#newcode62 content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc:62: // Devices nodes for V4L2 video decode accelerator drivers. ...
6 years ago (2014-12-09 18:04:23 UTC) #6
henryhsu
On 2014/12/09 18:04:23, Jorge Lucangeli Obes wrote: > https://codereview.chromium.org/786993002/diff/20001/content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc > File content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc (right): > > ...
6 years ago (2014-12-10 02:22:52 UTC) #7
Jorge Lucangeli Obes
lgtm
6 years ago (2014-12-10 05:58:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786993002/40001
6 years ago (2014-12-10 07:43:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/7437)
6 years ago (2014-12-10 09:48:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786993002/40001
6 years ago (2014-12-10 09:53:58 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-10 10:39:02 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b777ad3f16655a3493a0ecd9975c58a7b84c740d Cr-Commit-Position: refs/heads/master@{#307674}
6 years ago (2014-12-10 10:39:42 UTC) #16
Pawel Osciak
6 years ago (2014-12-13 07:03:50 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/792123006/ by posciak@chromium.org.

The reason for reverting is: Still hitting crbug.com/439175 on Pit..

Powered by Google App Engine
This is Rietveld 408576698